Generate enum/getters/setters/mappings for text-orientation.

Generate enum/getters/setters/mappings for text-orientation.

Currently, the text-orientation property is a 'storage_only' field,
so it has no generated public getters/setters. This patch changes it to
a 'keyword' field so that its getters/setters can be generated as well.
We also generate the ETextOrientation enum and use the generated
CSSValueID <-> ETextOrientation mappings.

Diff: https://gist.github.com/nainar/257662e77043a84cf3def269576e534a/revisions

BUG=628043
Review-Url: https://codereview.chromium.org/2913723002
Cr-Commit-Position: refs/heads/master@{#475880}
Committed: https://chromium.googlesource.com/chromium/src/+/f3833029711d581ebebedaeaf3412b2463c857ea

[nainar, 2017-05-30 05:55:34]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 05:56:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nainar, 2017-05-30 05:57:25]

Description was changed from

==========
Generate enum/getters/setters/mappings for text-orientation.

Currently, the text-orientation property is a 'storage_only' field,
so it has no generated public getters/setters. This patch changes it to
a 'keyword' field so that its getters/setters can be generated as well.
We also generate the ETextOrientation enum and use the generated
CSSValueID <-> ETextOrientation mappings.

Diff: https://gist.github.com/nainar/241d81102eaa56c2d35b997a24bc4228/revisions

BUG=628043
==========

to

==========
Generate enum/getters/setters/mappings for text-orientation.

Currently, the text-orientation property is a 'storage_only' field,
so it has no generated public getters/setters. This patch changes it to
a 'keyword' field so that its getters/setters can be generated as well.
We also generate the ETextOrientation enum and use the generated
CSSValueID <-> ETextOrientation mappings.

Diff: https://gist.github.com/nainar/257662e77043a84cf3def269576e534a/revisions

BUG=628043
==========

[nainar, 2017-05-30 05:57:25]

nainar@chromium.org changed reviewers:
+ shend@chromium.org

[commit-bot: I haz the power, 2017-05-30 07:13:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 07:13:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nainar, 2017-05-30 09:05:09]

shend@, 

This crashes in case you pass a differing value to the three accepted which
fast/css/vertical-text-overflow-ellipsis-text-align-center.html does. It passes
sideways-right. 

It crashes whereas before it didn't because there was no NOTREACHED() as you can
see in the diff.

I will explore this in the morning.

[shend, 2017-05-30 20:48:43]

https://codereview.chromium.org/2913723002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h (left):

https://codereview.chromium.org/2913723002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h:1625: case
CSSValueSidewaysRight:
Special case here, gotta override it in CSSValueIDMappings.h

https://codereview.chromium.org/2913723002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h:1628: case
CSSValueVerticalRight:  // -webkit-text-orientation
Same here.

[nainar, 2017-05-31 03:59:12]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 03:59:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nainar, 2017-05-31 03:59:57]

shend@, 

PTAL? 

Thanks!

https://codereview.chromium.org/2913723002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h (left):

https://codereview.chromium.org/2913723002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h:1625: case
CSSValueSidewaysRight:
Done.

https://codereview.chromium.org/2913723002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h:1628: case
CSSValueVerticalRight:  // -webkit-text-orientation
Done.

[shend, 2017-05-31 04:28:33]

lgtm

[commit-bot: I haz the power, 2017-05-31 05:17:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 05:17:46]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nainar, 2017-05-31 05:22:07]

The CQ bit was checked by nainar@chromium.org

[commit-bot: I haz the power, 2017-05-31 05:22:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 05:29:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 05:29:31]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nainar, 2017-05-31 05:31:19]

nainar@chromium.org changed reviewers:
+ meade@chromium.org

[nainar, 2017-05-31 05:31:20]

meade@, 

PTAL? Thanks!

[meade_UTC10, 2017-05-31 06:02:46]

lgtm

looks like you need to rebase, linux_chromium_rel_ng had a patch error :/

[nainar, 2017-05-31 07:46:36]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[nainar, 2017-05-31 07:46:42]

The CQ bit was unchecked by nainar@chromium.org

[nainar, 2017-05-31 07:46:46]

The CQ bit was checked by nainar@chromium.org

[nainar, 2017-05-31 07:46:47]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org,
shend@chromium.org
Link to the patchset: https://codereview.chromium.org/2913723002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-31 07:46:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 11:52:03]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496216806489900,
"parent_rev": "54dae1cef7f1f646ad3523eb3cc749e912d0a92c", "commit_rev":
"f3833029711d581ebebedaeaf3412b2463c857ea"}

[commit-bot: I haz the power, 2017-05-31 11:52:13]

Description was changed from

==========
Generate enum/getters/setters/mappings for text-orientation.

Currently, the text-orientation property is a 'storage_only' field,
so it has no generated public getters/setters. This patch changes it to
a 'keyword' field so that its getters/setters can be generated as well.
We also generate the ETextOrientation enum and use the generated
CSSValueID <-> ETextOrientation mappings.

Diff: https://gist.github.com/nainar/257662e77043a84cf3def269576e534a/revisions

BUG=628043
==========

to

==========
Generate enum/getters/setters/mappings for text-orientation.

Currently, the text-orientation property is a 'storage_only' field,
so it has no generated public getters/setters. This patch changes it to
a 'keyword' field so that its getters/setters can be generated as well.
We also generate the ETextOrientation enum and use the generated
CSSValueID <-> ETextOrientation mappings.

Diff: https://gist.github.com/nainar/257662e77043a84cf3def269576e534a/revisions

BUG=628043

Review-Url: https://codereview.chromium.org/2913723002
Cr-Commit-Position: refs/heads/master@{#475880}
Committed:
https://chromium.googlesource.com/chromium/src/+/f3833029711d581ebebedaeaf341...
==========

[commit-bot: I haz the power, 2017-05-31 11:52:14]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f3833029711d581ebebedaeaf341...