third_party/WebKit/Source/core/css/resolver/FontBuilder.cpp - Issue 2913723002: Generate enum/getters/setters/mappings for text-orientation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/FontBuilder.cpp

Issue 2913723002: Generate enum/getters/setters/mappings for text-orientation. (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/resolver/FontBuilder.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/FontBuilder.cpp b/third_party/WebKit/Source/core/css/resolver/FontBuilder.cpp

index 56601c2ed71c0f35ca2f2c4cf688d47df229cb2e..0e05ce9476af3aa9632251220ff7117c796575de 100644

--- a/third_party/WebKit/Source/core/css/resolver/FontBuilder.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/FontBuilder.cpp

@@ -242,11 +242,11 @@ static FontOrientation ComputeFontOrientation(const ComputedStyle& style) {

return FontOrientation::kHorizontal;

switch (style.GetTextOrientation()) {

- case TextOrientation::kMixed:

+ case ETextOrientation::kMixed:

return FontOrientation::kVerticalMixed;

- case TextOrientation::kUpright:

+ case ETextOrientation::kUpright:

return FontOrientation::kVerticalUpright;

- case TextOrientation::kSideways:

+ case ETextOrientation::kSideways:

return FontOrientation::kVerticalRotated;

default:

NOTREACHED();