Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 2913403003: v8binding: Fixes static readonly wrapper-returning attributes. (Closed)

Created:
3 years, 6 months ago by Yuki
Modified:
3 years, 6 months ago
Reviewers:
haraken, peria
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org, nhiroki
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

v8binding: Fixes static readonly wrapper-returning attributes. static attributes must not be "keep_alive_gc". keep_alive_gc is a mechanism to associate a returned object with the receiver object, however static attributes must not use the receiver object. BUG= Review-Url: https://codereview.chromium.org/2913403003 Cr-Commit-Position: refs/heads/master@{#476231} Committed: https://chromium.googlesource.com/chromium/src/+/808a9e88c43fb74ac5554d5dc7e621158937bcce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -25 lines) Patch
M third_party/WebKit/Source/bindings/scripts/v8_attributes.py View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp View 2 chunks +1 line, -13 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 1 chunk +1 line, -12 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Yuki
There was no use of static readonly wrapper-returning attributes, however, https://crrev.com/2896773002 is going to use ...
3 years, 6 months ago (2017-06-01 07:35:58 UTC) #2
peria
lgtm
3 years, 6 months ago (2017-06-01 07:40:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2913403003/1
3 years, 6 months ago (2017-06-01 07:44:20 UTC) #5
haraken
LGTM
3 years, 6 months ago (2017-06-01 07:53:56 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 09:17:26 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/808a9e88c43fb74ac5554d5dc7e6...

Powered by Google App Engine
This is Rietveld 408576698