Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp

Issue 2913403003: v8binding: Fixes static readonly wrapper-returning attributes. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp
index 9c8583a8bde2bf041ad6b95adfde9e409bb7b02b..c04159e5b98f97a514d93b89f412a5658975c6ff 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp
@@ -4200,18 +4200,7 @@ static void staticSaveSameObjectAttributeAttributeGetter(const v8::FunctionCallb
}
}
- TestInterfaceImplementation* cppValue(WTF::GetPtr(TestObject::staticSaveSameObjectAttribute()));
-
- // Keep the wrapper object for the return value alive as long as |this|
- // object is alive in order to save creation time of the wrapper object.
- if (cppValue && DOMDataStore::SetReturnValue(info.GetReturnValue(), cppValue))
- return;
- v8::Local<v8::Value> v8Value(ToV8(cppValue, holder, info.GetIsolate()));
- V8PrivateProperty::GetSymbol(
- info.GetIsolate(), "KeepAlive#TestObject#staticSaveSameObjectAttribute")
- .Set(holder, v8Value);
-
- V8SetReturnValue(info, v8Value);
+ V8SetReturnValue(info, WTF::GetPtr(TestObject::staticSaveSameObjectAttribute()), info.GetIsolate()->GetCurrentContext()->Global());
// [SaveSameObject]
privateSameObject.Set(holder, info.GetReturnValue().Get());
« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698