third_party/WebKit/Source/bindings/scripts/v8_attributes.py - Issue 2913403003: v8binding: Fixes static readonly wrapper-returning attributes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_attributes.py

Issue 2913403003: v8binding: Fixes static readonly wrapper-returning attributes. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/scripts/v8_attributes.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_attributes.py b/third_party/WebKit/Source/bindings/scripts/v8_attributes.py

index c88be2b30bec854c7f1c83e5ffff1cfce7e4b4e3..940e8f6002230d32efcf8c44be1d2fcebbc04fc7 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_attributes.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_attributes.py

@@ -365,6 +365,8 @@ def is_keep_alive_for_gc(interface, attribute):

idl_type = attribute.idl_type

base_idl_type = idl_type.base_type

extended_attributes = attribute.extended_attributes

+ if attribute.is_static:

+ return False

return (

# For readonly attributes, for performance reasons we keep the attribute

# wrapper alive while the owner wrapper is alive, because the attribute

« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp » ('j') | no next file with comments »