Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2913153002: Add RuntimeError to default expectations and handle expectation groups correctly. (Closed)

Created:
3 years, 6 months ago by ahe
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, Paul Berry
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add RuntimeError to default expectations and handle expectation groups correctly. R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/c4481e2384d9540c6b71eaf9d4223e951696d5e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -2 lines) Patch
M pkg/testing/lib/src/chain.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/testing/lib/src/expectation.dart View 2 chunks +23 lines, -0 lines 0 comments Download
M pkg/testing/lib/src/stdio_process.dart View 2 chunks +4 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
ahe
3 years, 6 months ago (2017-05-31 11:56:47 UTC) #2
Johnni Winther
lgtm
3 years, 6 months ago (2017-05-31 12:46:30 UTC) #3
ahe
3 years, 6 months ago (2017-05-31 13:02:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c4481e2384d9540c6b71eaf9d4223e951696d5e3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698