Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2912353002: Don't read platform files during testing, and avoid trimming broken programs. (Closed)

Created:
3 years, 6 months ago by ahe
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, Siggi Cherem (dart-lang), scheglov
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't read platform files during testing, and avoid trimming broken programs. R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/cdfd07b9d3080a4af0f742e74a3b0638a5521cd2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -6 lines) Patch
M pkg/front_end/lib/src/fasta/compiler_context.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/test/fasta/compile.status View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/front_end/test/fasta/kompile.status View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/front_end/test/fasta/testing/suite.dart View 2 chunks +14 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/rasta/unsupported_platform_library.dart.dartk.expect View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/rasta/unsupported_platform_library.dart.direct.expect View 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (9 generated)
ahe
3 years, 6 months ago (2017-05-31 12:11:32 UTC) #7
Johnni Winther
lgtm
3 years, 6 months ago (2017-05-31 12:44:27 UTC) #8
ahe
Committed patchset #1 (id:100001) manually as cdfd07b9d3080a4af0f742e74a3b0638a5521cd2 (presubmit successful).
3 years, 6 months ago (2017-05-31 13:03:48 UTC) #10
Siggi Cherem (dart-lang)
lgtm - sorry for the unintentional break
3 years, 6 months ago (2017-05-31 15:59:50 UTC) #12
scheglov
3 years, 6 months ago (2017-05-31 16:13:06 UTC) #14
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698