Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: pkg/testing/lib/src/stdio_process.dart

Issue 2913153002: Add RuntimeError to default expectations and handle expectation groups correctly. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/testing/lib/src/expectation.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/testing/lib/src/stdio_process.dart
diff --git a/pkg/testing/lib/src/stdio_process.dart b/pkg/testing/lib/src/stdio_process.dart
index 8f0f747f85e9660aba637a4b7dd36ecd55c66035..8fff926c3d45542256fa6d4cadfd97e94351d790 100644
--- a/pkg/testing/lib/src/stdio_process.dart
+++ b/pkg/testing/lib/src/stdio_process.dart
@@ -14,6 +14,8 @@ import 'dart:io' as io show stderr, stdout;
import 'chain.dart' show Result;
+import 'expectation.dart' show ExpectationSet;
+
class StdioProcess {
final int exitCode;
@@ -25,7 +27,8 @@ class StdioProcess {
if (exitCode == expected) {
return new Result<int>.pass(exitCode);
} else {
- return new Result<int>.fail(exitCode, output);
+ return new Result<Program>(
+ exitCode, ExpectationSet.Default["RuntimeError"], output, null);
}
}
« no previous file with comments | « pkg/testing/lib/src/expectation.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698