Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: pkg/testing/lib/src/chain.dart

Issue 2913153002: Add RuntimeError to default expectations and handle expectation groups correctly. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/testing/lib/src/expectation.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/testing/lib/src/chain.dart
diff --git a/pkg/testing/lib/src/chain.dart b/pkg/testing/lib/src/chain.dart
index d51fdb27302ebeba96023adc4ec0adbad2c895a2..022db73b84662e1eb2e45bab0708e76c15fa0e2b 100644
--- a/pkg/testing/lib/src/chain.dart
+++ b/pkg/testing/lib/src/chain.dart
@@ -205,7 +205,8 @@ abstract class ChainContext {
}
result = toNegativeTestResult(result);
}
- if (!expectedOutcomes.contains(result.outcome)) {
+ if (!expectedOutcomes.contains(result.outcome) &&
+ !expectedOutcomes.contains(result.outcome.canonical)) {
result.addLog("$sb");
unexpectedResults[description] = result;
unexpectedOutcomes[description] = expectedOutcomes;
« no previous file with comments | « no previous file | pkg/testing/lib/src/expectation.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698