Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2912993002: Call WebStateObserver::DidStopLoading for native content reloads. (Closed)

Created:
3 years, 6 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Call WebStateObserver::DidStopLoading for native content reloads. This has regressed after https://codereview.chromium.org/2902083003/ BUG=726477 Review-Url: https://codereview.chromium.org/2910663002 Cr-Original-Commit-Position: refs/heads/master@{#475525} Review-Url: https://codereview.chromium.org/2912993002 . Cr-Commit-Position: refs/branch-heads/3112@{#32} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/cc77f39ceb69538ec88a8ee668a749d15e5e8780

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -16 lines) Patch
M ios/web/web_state/navigation_callbacks_inttest.mm View 19 chunks +280 lines, -14 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Eugene But (OOO till 7-30)
3 years, 6 months ago (2017-05-30 16:50:07 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cc77f39ceb69538ec88a8ee668a749d15e5e8780.

Powered by Google App Engine
This is Rietveld 408576698