Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: ios/web/web_state/ui/crw_web_controller.mm

Issue 2912993002: Call WebStateObserver::DidStopLoading for native content reloads. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/web_state/navigation_callbacks_inttest.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/web_state/ui/crw_web_controller.mm
diff --git a/ios/web/web_state/ui/crw_web_controller.mm b/ios/web/web_state/ui/crw_web_controller.mm
index ec226cd249b5f432585fc920048c2a1b8fdfed8c..f02a13df647d98c05f399d23064364bce8b66419 100644
--- a/ios/web/web_state/ui/crw_web_controller.mm
+++ b/ios/web/web_state/ui/crw_web_controller.mm
@@ -2038,6 +2038,7 @@ registerLoadRequestForURL:(const GURL&)requestURL
registerLoadRequestForURL:url
referrer:self.currentNavItemReferrer
transition:ui::PageTransition::PAGE_TRANSITION_RELOAD];
+ [self didStartLoadingURL:url];
[self.nativeController reload];
_webStateImpl->OnNavigationFinished(navigationContext.get());
[self loadCompleteWithSuccess:YES forNavigation:nil];
@@ -2140,8 +2141,6 @@ registerLoadRequestForURL:(const GURL&)requestURL
if (_loadPhase != web::PAGE_LOADING)
return;
- DCHECK(_webView);
-
const GURL currentURL([self currentURL]);
_loadPhase = web::PAGE_LOADED;
« no previous file with comments | « ios/web/web_state/navigation_callbacks_inttest.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698