Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2910663002: Call WebStateObserver::DidStopLoading for native content reloads. (Closed)

Created:
3 years, 7 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 6 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Call WebStateObserver::DidStopLoading for native content reloads. This has regressed after https://codereview.chromium.org/2902083003/ BUG=726477 Review-Url: https://codereview.chromium.org/2910663002 Cr-Commit-Position: refs/heads/master@{#475525} Committed: https://chromium.googlesource.com/chromium/src/+/8342ede4675b43769aa85569ee216e63b0efa39b

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -18 lines) Patch
M ios/web/web_state/navigation_callbacks_inttest.mm View 24 chunks +69 lines, -16 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 2 chunks +1 line, -2 lines 1 comment Download

Depends on Patchset:

Messages

Total messages: 17 (12 generated)
Eugene But (OOO till 7-30)
PTAL ios_simulator failure is unrelated https://codereview.chromium.org/2910663002/diff/1/ios/web/web_state/ui/crw_web_controller.mm File ios/web/web_state/ui/crw_web_controller.mm (left): https://codereview.chromium.org/2910663002/diff/1/ios/web/web_state/ui/crw_web_controller.mm#oldcode2142 ios/web/web_state/ui/crw_web_controller.mm:2142: DCHECK(_webView); This is now ...
3 years, 7 months ago (2017-05-26 17:36:32 UTC) #7
kkhorimoto
lgtm
3 years, 7 months ago (2017-05-26 17:42:29 UTC) #9
Eugene But (OOO till 7-30)
Thanks for a quick review!
3 years, 7 months ago (2017-05-26 17:49:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2910663002/1
3 years, 6 months ago (2017-05-30 14:47:42 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 15:01:38 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8342ede4675b43769aa85569ee21...

Powered by Google App Engine
This is Rietveld 408576698