[Extensions Bindings] Don't allow `event` module with native bindings

extensions/renderer/declarative_event.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/declarative_event.h"
 
 #include <algorithm>
 #include <memory>
 
 #include "base/memory/ptr_util.h"
@@ skipping 96 matching lines @@
 
 }  // namespace
 
 gin::WrapperInfo DeclarativeEvent::kWrapperInfo = {gin::kEmbedderNativeGin};
 
 DeclarativeEvent::DeclarativeEvent(
     const std::string& name,
     APITypeReferenceMap* type_refs,
     APIRequestHandler* request_handler,
     const std::vector<std::string>& actions_list,
-    const std::vector<std::string>& conditions_list)
+    const std::vector<std::string>& conditions_list,
+    int webview_instance_id)
     : event_name_(name),
       type_refs_(type_refs),
-      request_handler_(request_handler) {
+      request_handler_(request_handler),
+      webview_instance_id_(webview_instance_id) {
   // In declarative events, the specification of the rules can change. This only
   // matters for the events.addRules function. Check whether or not a
   // specialized version for this event exists, and, if not, create it.
   std::string add_rules_name = name + ".addRules";
   if (!type_refs->HasTypeMethodSignature(add_rules_name)) {
     // Create the specific rules spec and cache it under this type. This will
     // result in e.g. declarativeContent.onPageChanged.Rule, since the Rule
     // schema is only used for this event.
     std::unique_ptr<ArgumentSpec> rules_spec =
         BuildRulesSpec(actions_list, conditions_list);
@@ skipping 41 matching lines @@
                                       gin::Arguments* arguments) {
   v8::Isolate* isolate = arguments->isolate();
   v8::HandleScope handle_scope(isolate);
   v8::Local<v8::Context> context = arguments->GetHolderCreationContext();
 
   std::vector<v8::Local<v8::Value>> argument_list = arguments->GetAll();
 
   // The events API has two undocumented parameters for each function: the name
   // of the event, and the "webViewInstanceId". Currently, stub 0 for webview
   // instance id.
-  // TODO(devlin): We'll need to fix that to get it to work with webviews.
-  // Longer term, it would be *great* to just factor that out entirely (can we
-  // not get that information on the browser side? Investigate).
   argument_list.insert(argument_list.begin(),
                        {gin::StringToSymbol(isolate, event_name_),
-                        v8::Integer::New(isolate, 0)});
+                        v8::Integer::New(isolate, webview_instance_id_)});
 
   std::unique_ptr<base::ListValue> converted_arguments;
   v8::Local<v8::Function> callback;
   std::string error;
   const APISignature* signature =
       type_refs_->GetTypeMethodSignature(signature_name);
   DCHECK(signature);
   if (!signature->ParseArgumentsToJSON(context, argument_list, *type_refs_,
                                        &converted_arguments, &callback,
                                        &error)) {
     arguments->ThrowTypeError("Invalid invocation");
     return;
   }
 
   request_handler_->StartRequest(
       context, request_name, std::move(converted_arguments), callback,
       v8::Local<v8::Function>(), binding::RequestThread::UI);
 }
 
 }  // namespace extensions