Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Side by Side Diff: extensions/renderer/api_binding.cc

Issue 2912883004: [Extensions Bindings] Don't allow `event` module with native bindings (Closed)
Patch Set: lazyboy's Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/renderer/api_binding.h" 5 #include "extensions/renderer/api_binding.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 479 matching lines...) Expand 10 before | Expand all | Expand 10 after
490 static_cast<EventData*>(info.Data().As<v8::External>()->Value()); 490 static_cast<EventData*>(info.Data().As<v8::External>()->Value());
491 v8::Local<v8::Value> retval; 491 v8::Local<v8::Value> retval;
492 if (event_data->binding->binding_hooks_->CreateCustomEvent( 492 if (event_data->binding->binding_hooks_->CreateCustomEvent(
493 context, event_data->full_name, &retval)) { 493 context, event_data->full_name, &retval)) {
494 // A custom event was created; our work is done. 494 // A custom event was created; our work is done.
495 } else if (event_data->supports_rules) { 495 } else if (event_data->supports_rules) {
496 gin::Handle<DeclarativeEvent> event = gin::CreateHandle( 496 gin::Handle<DeclarativeEvent> event = gin::CreateHandle(
497 isolate, new DeclarativeEvent( 497 isolate, new DeclarativeEvent(
498 event_data->full_name, event_data->binding->type_refs_, 498 event_data->full_name, event_data->binding->type_refs_,
499 event_data->binding->request_handler_, event_data->actions, 499 event_data->binding->request_handler_, event_data->actions,
500 event_data->conditions)); 500 event_data->conditions, 0));
501 retval = event.ToV8(); 501 retval = event.ToV8();
502 } else { 502 } else {
503 retval = event_data->binding->event_handler_->CreateEventInstance( 503 retval = event_data->binding->event_handler_->CreateEventInstance(
504 event_data->full_name, event_data->supports_filters, 504 event_data->full_name, event_data->supports_filters,
505 event_data->max_listeners, event_data->notify_on_change, context); 505 event_data->max_listeners, event_data->notify_on_change, context);
506 } 506 }
507 info.GetReturnValue().Set(retval); 507 info.GetReturnValue().Set(retval);
508 } 508 }
509 509
510 void APIBinding::GetCustomPropertyObject( 510 void APIBinding::GetCustomPropertyObject(
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
626 arguments->ThrowTypeError(api_errors::InvocationError( 626 arguments->ThrowTypeError(api_errors::InvocationError(
627 name, signature->GetExpectedSignature(), error)); 627 name, signature->GetExpectedSignature(), error));
628 return; 628 return;
629 } 629 }
630 630
631 request_handler_->StartRequest(context, name, std::move(converted_arguments), 631 request_handler_->StartRequest(context, name, std::move(converted_arguments),
632 callback, custom_callback, thread); 632 callback, custom_callback, thread);
633 } 633 }
634 634
635 } // namespace extensions 635 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/renderer/resources/extensions/web_view/chrome_web_view.js ('k') | extensions/renderer/api_binding_js_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698