Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Unified Diff: third_party/WebKit/Source/core/editing/iterators/TextIterator.h

Issue 2912283002: Use remembered progress to handle replaced elements in TextIterator (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/iterators/TextIterator.h
diff --git a/third_party/WebKit/Source/core/editing/iterators/TextIterator.h b/third_party/WebKit/Source/core/editing/iterators/TextIterator.h
index 9e72c11cedb3b28e9f71f73dd56eab0676a1a012..0c73bd561a545b3fbe6c90a065fd5a061e733f15 100644
--- a/third_party/WebKit/Source/core/editing/iterators/TextIterator.h
+++ b/third_party/WebKit/Source/core/editing/iterators/TextIterator.h
@@ -222,8 +222,9 @@ class CORE_TEMPLATE_CLASS_EXPORT TextIteratorAlgorithm {
Member<Node> past_end_node_;
// Used when there is still some pending text from the current node; when
- // these are false and 0, we go back to normal iterating.
+ // these are false, we go back to normal iterating.
bool needs_another_newline_;
+ bool needs_handle_replaced_element_;
yosin_UTC9 2017/05/31 07:23:01 nit: Initialize needs_handle_replaced_element_ her
Xiaocheng 2017/05/31 18:05:58 I've added a TODO in the .cpp file that most membe
Member<Text> last_text_node_;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698