Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2912253003:
MD Settings: Show all content settings in Site Details. (Closed)
|
Created:
3 years, 6 months ago by Patti Lor Modified:
3 years, 6 months ago CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: Show all content settings in Site Details.
The "Site Details" page currently only shows content settings that are set to a
non-default setting for the given origin. This patch will show all content
settings in "Site Details", regardless of whether they are still set to the
default setting or not.
BUG=656758, 709171
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2912253003
Cr-Commit-Position: refs/heads/master@{#476514}
Committed: https://chromium.googlesource.com/chromium/src/+/f6d2eeee539252388096d5ddaf5644c093ad6c13
Patch Set 1 #Patch Set 2 : Remove tests which are no longer needed, fix other tests. #Patch Set 3 : Delete Site Details test that checks permissions are hidden. #
Total comments: 4
Patch Set 4 : Review comments. #
Messages
Total messages: 36 (27 generated)
Description was changed from ========== MD Settings: Show all content settings in Site Details. The "Site Details" page currently only shows content settings that are set to a non-default setting for the given origin. This patch will show all of them. BUG=656758 ========== to ========== MD Settings: Show all content settings in Site Details. The "Site Details" page currently only shows content settings that are set to a non-default setting for the given origin. This patch will show all of them. BUG=656758 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by patricialor@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== MD Settings: Show all content settings in Site Details. The "Site Details" page currently only shows content settings that are set to a non-default setting for the given origin. This patch will show all of them. BUG=656758 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Show all content settings in Site Details. The "Site Details" page currently only shows content settings that are set to a non-default setting for the given origin. This patch will show all content settings in "Site Details", regardless of whether they are still set to the default setting or not. BUG=656758 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by patricialor@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
patricialor@chromium.org changed reviewers: + calamity@chromium.org
Hi Chris, PTAL?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by patricialor@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by patricialor@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #3 (id:40001) has been deleted
Mostly lg! https://codereview.chromium.org/2912253003/diff/60001/chrome/test/data/webui/... File chrome/test/data/webui/settings/site_details_permission_tests.js (right): https://codereview.chromium.org/2912253003/diff/60001/chrome/test/data/webui/... chrome/test/data/webui/settings/site_details_permission_tests.js:53: // failures on undefined icons. In practice, this is done from the parent. nit: ...icons during teardown in PolymerTest.testIronIcons. https://codereview.chromium.org/2912253003/diff/60001/chrome/test/data/webui/... File chrome/test/data/webui/settings/site_details_tests.js (right): https://codereview.chromium.org/2912253003/diff/60001/chrome/test/data/webui/... chrome/test/data/webui/settings/site_details_tests.js:141: assertTrue(!!testElement.$.unsandboxedPlugins); I don't this tests what you want it to. It just checks the the element exists, which will always be true. I think it's fine to remove this whole test.
The CQ bit was checked by patricialor@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2912253003/diff/60001/chrome/test/data/webui/... File chrome/test/data/webui/settings/site_details_permission_tests.js (right): https://codereview.chromium.org/2912253003/diff/60001/chrome/test/data/webui/... chrome/test/data/webui/settings/site_details_permission_tests.js:53: // failures on undefined icons. In practice, this is done from the parent. On 2017/06/01 03:46:56, calamity wrote: > nit: ...icons during teardown in PolymerTest.testIronIcons. Done. https://codereview.chromium.org/2912253003/diff/60001/chrome/test/data/webui/... File chrome/test/data/webui/settings/site_details_tests.js (right): https://codereview.chromium.org/2912253003/diff/60001/chrome/test/data/webui/... chrome/test/data/webui/settings/site_details_tests.js:141: assertTrue(!!testElement.$.unsandboxedPlugins); On 2017/06/01 03:46:56, calamity wrote: > I don't this tests what you want it to. It just checks the the element exists, > which will always be true. I think it's fine to remove this whole test. Done! Thanks, I was kinda unsure if it was really that useful any more.
lgtm. lol, one of my comments missed a word. derp.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
patricialor@chromium.org changed reviewers: + dbeam@chromium.org
Hi dbeam@, PTAL for owner's review in chrome/browser/resources/settings/site_settings/* Thank you!
Description was changed from ========== MD Settings: Show all content settings in Site Details. The "Site Details" page currently only shows content settings that are set to a non-default setting for the given origin. This patch will show all content settings in "Site Details", regardless of whether they are still set to the default setting or not. BUG=656758 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Show all content settings in Site Details. The "Site Details" page currently only shows content settings that are set to a non-default setting for the given origin. This patch will show all content settings in "Site Details", regardless of whether they are still set to the default setting or not. BUG=656758 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
dbeam@chromium.org changed reviewers: + dschuyler@chromium.org - dbeam@chromium.org
-dbeam, +dschuyler
lgtm
Description was changed from ========== MD Settings: Show all content settings in Site Details. The "Site Details" page currently only shows content settings that are set to a non-default setting for the given origin. This patch will show all content settings in "Site Details", regardless of whether they are still set to the default setting or not. BUG=656758 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Show all content settings in Site Details. The "Site Details" page currently only shows content settings that are set to a non-default setting for the given origin. This patch will show all content settings in "Site Details", regardless of whether they are still set to the default setting or not. BUG=656758,709171 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by patricialor@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1496366526668460,
"parent_rev": "bcca0368ac116828cecc6c68a381bfc5147f8c98", "commit_rev":
"f6d2eeee539252388096d5ddaf5644c093ad6c13"}
Message was sent while issue was closed.
Description was changed from ========== MD Settings: Show all content settings in Site Details. The "Site Details" page currently only shows content settings that are set to a non-default setting for the given origin. This patch will show all content settings in "Site Details", regardless of whether they are still set to the default setting or not. BUG=656758,709171 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Show all content settings in Site Details. The "Site Details" page currently only shows content settings that are set to a non-default setting for the given origin. This patch will show all content settings in "Site Details", regardless of whether they are still set to the default setting or not. BUG=656758,709171 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2912253003 Cr-Commit-Position: refs/heads/master@{#476514} Committed: https://chromium.googlesource.com/chromium/src/+/f6d2eeee539252388096d5ddaf56... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as https://chromium.googlesource.com/chromium/src/+/f6d2eeee539252388096d5ddaf56... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
