Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4794)

Unified Diff: chrome/test/data/webui/settings/site_details_permission_tests.js

Issue 2912253003: MD Settings: Show all content settings in Site Details. (Closed)
Patch Set: Review comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/site_details_permission_tests.js
diff --git a/chrome/test/data/webui/settings/site_details_permission_tests.js b/chrome/test/data/webui/settings/site_details_permission_tests.js
index 309f555e82994c1370abc5c8dd7e895b025ed55c..58a654d0a8565e663387f1fcfbe0e2c413e368bb 100644
--- a/chrome/test/data/webui/settings/site_details_permission_tests.js
+++ b/chrome/test/data/webui/settings/site_details_permission_tests.js
@@ -48,6 +48,11 @@ suite('SiteDetailsPermission', function() {
settings.SiteSettingsPrefsBrowserProxyImpl.instance_ = browserProxy;
PolymerTest.clearBody();
testElement = document.createElement('site-details-permission');
+
+ // Set the camera icon on <site-details-permission> manually to avoid
+ // failures on undefined icons during teardown in PolymerTest.testIronIcons.
+ // In practice, this is done from the parent.
+ testElement.icon = 'settings:videocam';
document.body.appendChild(testElement);
});
@@ -77,19 +82,6 @@ suite('SiteDetailsPermission', function() {
});
};
- test('empty state', function() {
- browserProxy.setPrefs(prefsEmpty);
- testElement.category = settings.ContentSettingsTypes.CAMERA;
- testElement.site = {
- origin: 'http://www.google.com',
- embeddingOrigin: '',
- };
-
- return browserProxy.whenCalled('getExceptionList').then(function() {
- assertTrue(testElement.$.details.hidden);
- });
- });
-
test('camera category', function() {
var origin = 'https://www.example.com';
browserProxy.setPrefs(prefs);
@@ -155,25 +147,4 @@ suite('SiteDetailsPermission', function() {
origin, settings.PermissionValues.BLOCK);
});
});
-
- test('disappear on empty', function() {
- var origin = 'https://www.example.com';
- browserProxy.setPrefs(prefs);
- testElement.category = settings.ContentSettingsTypes.CAMERA;
- testElement.site = {
- origin: origin,
- embeddingOrigin: '',
- };
-
- return browserProxy.whenCalled('getExceptionList')
- .then(function() {
- assertFalse(testElement.$.details.hidden);
-
- browserProxy.setPrefs(prefsEmpty);
- return browserProxy.whenCalled('getExceptionList');
- })
- .then(function() {
- assertTrue(testElement.$.details.hidden);
- });
- });
});

Powered by Google App Engine
This is Rietveld 408576698