chrome/browser/resources/settings/site_settings/site_details_permission.js - Issue 2912253003: MD Settings: Show all content settings in Site Details.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/site_settings/site_details_permission.js

Issue 2912253003: MD Settings: Show all content settings in Site Details. (Closed)

Patch Set: Review comments. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/site_settings/site_details_permission.html ('k') | chrome/test/data/webui/settings/site_details_permission_tests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/site_settings/site_details_permission.js

diff --git a/chrome/browser/resources/settings/site_settings/site_details_permission.js b/chrome/browser/resources/settings/site_settings/site_details_permission.js

index 3408b6fa2edb88212a077d9df5c98575a57e5592..5cb99477cb0aab8b4f68381d2790a32098a018b2 100644

--- a/chrome/browser/resources/settings/site_settings/site_details_permission.js

+++ b/chrome/browser/resources/settings/site_settings/site_details_permission.js

@@ -52,7 +52,6 @@ Polymer({

* @private

siteChanged_: function(site) {

- this.$.details.hidden = true;

this.browserProxy.getExceptionList(this.category).then(

function(exceptionList) {

@@ -60,7 +59,6 @@ Polymer({

if (exceptionList[i].embeddingOrigin == site.embeddingOrigin &&

this.sameOrigin_(exceptionList[i].origin, site.origin)) {

this.$.permission.value = exceptionList[i].setting;

- this.$.details.hidden = false;

break;

}

@@ -94,7 +92,6 @@ Polymer({

this.browserProxy.resetCategoryPermissionForOrigin(

this.site.origin, this.site.embeddingOrigin, this.category,

this.site.incognito);

- this.$.details.hidden = true;

/**