|
Revert of Implement Element.scrollIntoView for scroll-behavior: smooth. (patchset #19 id:550001 of https://codereview.chromium.org/2650343008/ )
Reason for revert:
Looks this CL made the "WebKit Linux Trusty Leak" bot red.
See https://codereview.chromium.org/2650343008/#msg131
Original issue's description:
> Implement Element.scrollIntoView for scroll-behavior: smooth.
>
> Currently in Chrome, a call to Element.scrollIntoView will calculate the amount
> each scroller needs to scroll to align the Element as specified and instantly
> set the scroll position on that scroller (going from the innermost to the
> outermost scroller).
>
> If Element.scrollIntoView is called with scroll-behavior: smooth, instead of
> scrolling instantly, we should animate to the desired position.
>
> We can’t simply call setScrollPosition in PaintLayerScrollableArea and
> FrameView with ScrollBehaviorSmooth because of the following reasons:
> - We want to run the animation from the outermost scroller to the
> innermost scroller
> - We want to run the animation one after another. That is, the scroll animation
> on the child scroller should start after the animation on the parent scroller
> is finished.
>
> This patch adds a new class, ProgrammaticScrollCoordinator, that manages
> programmatic scroll animations.
>
> BUG= 648446
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Review-Url: https://codereview.chromium.org/2650343008
> Cr-Commit-Position: refs/heads/master@{#475387}
> Committed: https://chromium.googlesource.com/chromium/src/+/bbf870d971d95af7ae1ee688a7ed100e3787d02b
TBR=jbroman@chromium.org,bokan@chromium.org,ikilpatrick@chromium.org,sigbjornf@opera.com,sunyunjia@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 648446
Review-Url: https://codereview.chromium.org/2911103002
Cr-Commit-Position: refs/heads/master@{#475402}
Committed: https://chromium.googlesource.com/chromium/src/+/50ad23a34ff5e7d2a041c98991ef067209a8f41f
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+57 lines, -716 lines) |
Patch |
 |
D |
third_party/WebKit/LayoutTests/external/wpt/scroll-into-view/check-scroll-position.html
|
View
|
|
1 chunk |
+0 lines, -77 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/bindings/core/v8/BUILD.gn
|
View
|
|
2 chunks |
+0 lines, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/core_idl_files.gni
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/dom/Element.h
|
View
|
|
2 chunks |
+0 lines, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/dom/Element.cpp
|
View
|
|
4 chunks |
+12 lines, -76 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/dom/Element.idl
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/frame/LocalDOMWindow.h
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
|
View
|
|
4 chunks |
+6 lines, -18 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/frame/LocalFrameView.h
|
View
|
|
2 chunks |
+0 lines, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/frame/LocalFrameView.cpp
|
View
|
|
2 chunks |
+3 lines, -16 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/frame/RootFrameViewport.h
|
View
|
|
2 chunks |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/frame/RootFrameViewport.cpp
|
View
|
|
3 chunks |
+2 lines, -12 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/frame/RootFrameViewportTest.cpp
|
View
|
|
3 chunks |
+15 lines, -17 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/Source/core/frame/ScrollIntoViewOptions.idl
|
View
|
|
1 chunk |
+0 lines, -6 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/layout/LayoutBox.h
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/layout/LayoutBox.cpp
|
View
|
|
5 chunks |
+7 lines, -14 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/layout/LayoutListBox.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/layout/LayoutObject.h
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/layout/LayoutObject.cpp
|
View
|
|
1 chunk |
+2 lines, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/layout/ScrollAlignment.h
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/layout/ScrollAlignment.cpp
|
View
|
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/page/Page.h
|
View
|
|
3 chunks |
+0 lines, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/page/Page.cpp
|
View
|
|
3 chunks |
+0 lines, -9 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h
|
View
|
|
2 chunks |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
|
View
|
|
3 chunks |
+2 lines, -16 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/platform/BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/platform/geometry/FloatSize.h
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.h
|
View
|
|
2 chunks |
+1 line, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.cpp
|
View
|
|
4 chunks |
+1 line, -16 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/platform/scroll/ScrollTypes.h
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/platform/scroll/ScrollableArea.h
|
View
|
|
3 chunks |
+0 lines, -6 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp
|
View
|
|
3 chunks |
+1 line, -3 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/Source/platform/scroll/SmoothScrollSequencer.h
|
View
|
|
1 chunk |
+0 lines, -41 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/Source/platform/scroll/SmoothScrollSequencer.cpp
|
View
|
|
1 chunk |
+0 lines, -47 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/web/BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
D |
third_party/WebKit/Source/web/tests/SmoothScrollTest.cpp
|
View
|
|
1 chunk |
+0 lines, -288 lines |
0 comments
|
Download
|
Total messages: 7 (3 generated)
|