third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.h - Issue 2911103002: Revert of Implement Element.scrollIntoView for scroll-behavior: smooth.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.h

Issue 2911103002: Revert of Implement Element.scrollIntoView for scroll-behavior: smooth. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/geometry/FloatSize.h ('k') | third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.h

diff --git a/third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.h b/third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.h

index 8f1240fa127a5939d3dde87a419d3a1437a9c4f6..f8a365c32b9584f2e5efabc5ac292e62cd27e0b4 100644

--- a/third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.h

+++ b/third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.h

@@ -30,8 +30,7 @@

virtual ~ProgrammaticScrollAnimator();

void ScrollToOffsetWithoutAnimation(const ScrollOffset&);

- void AnimateToOffset(const ScrollOffset&,

- bool sequenced_for_smooth_scroll = false);

+ void AnimateToOffset(const ScrollOffset&);

// ScrollAnimatorCompositorCoordinator implementation.

void ResetAnimationState() override;

@@ -53,13 +52,11 @@

explicit ProgrammaticScrollAnimator(ScrollableArea*);

void NotifyOffsetChanged(const ScrollOffset&);

- void AnimationFinished();

Member<ScrollableArea> scrollable_area_;

std::unique_ptr<CompositorScrollOffsetAnimationCurve> animation_curve_;

ScrollOffset target_offset_;

double start_time_;

- bool sequenced_for_smooth_scroll_;

};

} // namespace blink