Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

Issue 2911103002: Revert of Implement Element.scrollIntoView for scroll-behavior: smooth. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
233 233
234 Scrollbar* HorizontalScrollbar() const override { 234 Scrollbar* HorizontalScrollbar() const override {
235 return scrollbar_manager_.HorizontalScrollbar(); 235 return scrollbar_manager_.HorizontalScrollbar();
236 } 236 }
237 Scrollbar* VerticalScrollbar() const override { 237 Scrollbar* VerticalScrollbar() const override {
238 return scrollbar_manager_.VerticalScrollbar(); 238 return scrollbar_manager_.VerticalScrollbar();
239 } 239 }
240 240
241 PlatformChromeClient* GetChromeClient() const override; 241 PlatformChromeClient* GetChromeClient() const override;
242 242
243 SmoothScrollSequencer* GetSmoothScrollSequencer() const override;
244
245 // For composited scrolling, we allocate an extra GraphicsLayer to hold 243 // For composited scrolling, we allocate an extra GraphicsLayer to hold
246 // onto the scrolling content. The layer can be shifted on the GPU and 244 // onto the scrolling content. The layer can be shifted on the GPU and
247 // composited at little cost. 245 // composited at little cost.
248 // Note that this is done in CompositedLayerMapping, this function being 246 // Note that this is done in CompositedLayerMapping, this function being
249 // only a helper. 247 // only a helper.
250 GraphicsLayer* LayerForScrolling() const override; 248 GraphicsLayer* LayerForScrolling() const override;
251 249
252 // GraphicsLayers for the scrolling components. 250 // GraphicsLayers for the scrolling components.
253 // 251 //
254 // Any function can return nullptr if they are not accelerated. 252 // Any function can return nullptr if they are not accelerated.
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
387 bool HitTestOverflowControls(HitTestResult&, const IntPoint& local_point); 385 bool HitTestOverflowControls(HitTestResult&, const IntPoint& local_point);
388 386
389 bool HitTestResizerInFragments(const PaintLayerFragments&, 387 bool HitTestResizerInFragments(const PaintLayerFragments&,
390 const HitTestLocation&) const; 388 const HitTestLocation&) const;
391 389
392 // Returns the new offset, after scrolling, of the given rect in absolute 390 // Returns the new offset, after scrolling, of the given rect in absolute
393 // coordinates, clipped by the parent's client rect. 391 // coordinates, clipped by the parent's client rect.
394 LayoutRect ScrollIntoView(const LayoutRect&, 392 LayoutRect ScrollIntoView(const LayoutRect&,
395 const ScrollAlignment& align_x, 393 const ScrollAlignment& align_x,
396 const ScrollAlignment& align_y, 394 const ScrollAlignment& align_y,
397 bool is_smooth,
398 ScrollType = kProgrammaticScroll) override; 395 ScrollType = kProgrammaticScroll) override;
399 396
400 // Returns true if scrollable area is in the FrameView's collection of 397 // Returns true if scrollable area is in the FrameView's collection of
401 // scrollable areas. This can only happen if we're scrollable, visible to hit 398 // scrollable areas. This can only happen if we're scrollable, visible to hit
402 // test, and do in fact overflow. This means that 'overflow: hidden' or 399 // test, and do in fact overflow. This means that 'overflow: hidden' or
403 // 'pointer-events: none' layers never get added to the FrameView's 400 // 'pointer-events: none' layers never get added to the FrameView's
404 // collection. 401 // collection.
405 bool ScrollsOverflow() const { return scrolls_overflow_; } 402 bool ScrollsOverflow() const { return scrolls_overflow_; }
406 403
407 // Rectangle encompassing the scroll corner and resizer rect. 404 // Rectangle encompassing the scroll corner and resizer rect.
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
615 612
616 DEFINE_TYPE_CASTS(PaintLayerScrollableArea, 613 DEFINE_TYPE_CASTS(PaintLayerScrollableArea,
617 ScrollableArea, 614 ScrollableArea,
618 scrollableArea, 615 scrollableArea,
619 scrollableArea->IsPaintLayerScrollableArea(), 616 scrollableArea->IsPaintLayerScrollableArea(),
620 scrollableArea.IsPaintLayerScrollableArea()); 617 scrollableArea.IsPaintLayerScrollableArea());
621 618
622 } // namespace blink 619 } // namespace blink
623 620
624 #endif // LayerScrollableArea_h 621 #endif // LayerScrollableArea_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/page/Page.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698