Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Issue 2910513003: Make TextDecorationSkip an enum class. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-paint_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, dshwang, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make TextDecorationSkip an enum class. This patch makes TextDecorationSkip an enum class for better type safety. BUG=684966 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2910513003 Cr-Commit-Position: refs/heads/master@{#474893} Committed: https://chromium.googlesource.com/chromium/src/+/c08b94e9b264f92b5478462b4846fa46ae1e1b9d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -14 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TextPainter.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
shend
Hi Alan, PTAL
3 years, 7 months ago (2017-05-25 23:59:58 UTC) #5
alancutter (OOO until 2018)
lgtm
3 years, 7 months ago (2017-05-26 01:51:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2910513003/1
3 years, 7 months ago (2017-05-26 03:03:24 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 03:09:50 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c08b94e9b264f92b5478462b4846...

Powered by Google App Engine
This is Rietveld 408576698