Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Side by Side Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

Issue 2910513003: Make TextDecorationSkip an enum class. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSProperties.json5 » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Alexey Proskuryakov <ap@nypop.com>. 2 * Copyright (C) 2007 Alexey Proskuryakov <ap@nypop.com>.
3 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 3 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
4 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. 4 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
5 * (http://www.torchmobile.com/) 5 * (http://www.torchmobile.com/)
6 * Copyright (C) 2009 Jeff Schiller <codedread@gmail.com> 6 * Copyright (C) 2009 Jeff Schiller <codedread@gmail.com>
7 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 7 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
8 * 8 *
9 * Redistribution and use in source and binary forms, with or without 9 * Redistribution and use in source and binary forms, with or without
10 * modification, are permitted provided that the following conditions 10 * modification, are permitted provided that the following conditions
(...skipping 1246 matching lines...) Expand 10 before | Expand all | Expand 10 after
1257 // FIXME: Implement support for 'under left' and 'under right' values. 1257 // FIXME: Implement support for 'under left' and 'under right' values.
1258 1258
1259 NOTREACHED(); 1259 NOTREACHED();
1260 return kTextUnderlinePositionAuto; 1260 return kTextUnderlinePositionAuto;
1261 } 1261 }
1262 1262
1263 template <> 1263 template <>
1264 inline TextDecorationSkip CSSIdentifierValue::ConvertTo() const { 1264 inline TextDecorationSkip CSSIdentifierValue::ConvertTo() const {
1265 switch (value_id_) { 1265 switch (value_id_) {
1266 case CSSValueObjects: 1266 case CSSValueObjects:
1267 return kTextDecorationSkipObjects; 1267 return TextDecorationSkip::kObjects;
1268 case CSSValueInk: 1268 case CSSValueInk:
1269 return kTextDecorationSkipInk; 1269 return TextDecorationSkip::kInk;
1270 default: 1270 default:
1271 break; 1271 break;
1272 } 1272 }
1273 1273
1274 NOTREACHED(); 1274 NOTREACHED();
1275 return kTextDecorationSkipObjects; 1275 return TextDecorationSkip::kObjects;
1276 } 1276 }
1277 1277
1278 template <> 1278 template <>
1279 inline CSSIdentifierValue::CSSIdentifierValue(ETextSecurity e) 1279 inline CSSIdentifierValue::CSSIdentifierValue(ETextSecurity e)
1280 : CSSValue(kIdentifierClass) { 1280 : CSSValue(kIdentifierClass) {
1281 switch (e) { 1281 switch (e) {
1282 case ETextSecurity::kNone: 1282 case ETextSecurity::kNone:
1283 value_id_ = CSSValueNone; 1283 value_id_ = CSSValueNone;
1284 break; 1284 break;
1285 case ETextSecurity::kDisc: 1285 case ETextSecurity::kDisc:
(...skipping 2006 matching lines...) Expand 10 before | Expand all | Expand 10 after
3292 default: 3292 default:
3293 break; 3293 break;
3294 } 3294 }
3295 NOTREACHED(); 3295 NOTREACHED();
3296 return kContainsNone; 3296 return kContainsNone;
3297 } 3297 }
3298 3298
3299 } // namespace blink 3299 } // namespace blink
3300 3300
3301 #endif 3301 #endif
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSProperties.json5 » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698