third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp - Issue 2910513003: Make TextDecorationSkip an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

Issue 2910513003: Make TextDecorationSkip an enum class. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSProperties.json5 ('k') | third_party/WebKit/Source/core/paint/TextPainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

diff --git a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

index 1192364103285936c159c24209515a8382b4ff2e..f2d0efa1c63ccf17be0452f68a993fed2582d9ea 100644

--- a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

+++ b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

@@ -1174,9 +1174,9 @@ static CSSValue* ValueForTextDecorationStyle(

static CSSValue* ValueForTextDecorationSkip(

TextDecorationSkip text_decoration_skip) {

CSSValueList* list = CSSValueList::CreateSpaceSeparated();

- if (text_decoration_skip & kTextDecorationSkipObjects)

+ if (EnumHasFlags(text_decoration_skip, TextDecorationSkip::kObjects))

list->Append(*CSSIdentifierValue::Create(CSSValueObjects));

- if (text_decoration_skip & kTextDecorationSkipInk)

+ if (EnumHasFlags(text_decoration_skip, TextDecorationSkip::kInk))

list->Append(*CSSIdentifierValue::Create(CSSValueInk));

DCHECK(list->length());

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSProperties.json5 ('k') | third_party/WebKit/Source/core/paint/TextPainter.cpp » ('j') | no next file with comments »