[CRD iOS] Fix telemetry issues

[CRD iOS] Fix telemetry issues

This CL fixes these issues:
* Previously the client OS is reported as Mac. That's because the OS_MACOSX
  macro is actually defined on iOS.
* Added the HostOs/HostVersion/HostOsVersion into the telemetry pipeline.

BUG=610866
Review-Url: https://codereview.chromium.org/2910513002
Cr-Commit-Position: refs/heads/master@{#474835}
Committed: https://chromium.googlesource.com/chromium/src/+/f9ad97d4a86c4820fb02d73fb28bcd34ec4e3428

[Yuwei, 2017-05-25 19:33:09]

yuweih@chromium.org changed reviewers:
+ nicholss@chromium.org

[Yuwei, 2017-05-25 19:33:10]

PTAL thanks!

[Yuwei, 2017-05-25 19:47:22]

The CQ bit was checked by yuweih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 19:48:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 20:37:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 20:37:35]

Dry run: This issue passed the CQ dry run.

[nicholss, 2017-05-25 21:51:47]

lgtm with a minor refactor.

https://codereview.chromium.org/2910513002/diff/20001/remoting/ios/facade/rem...
File remoting/ios/facade/remoting_service.mm (right):

https://codereview.chromium.org/2910513002/diff/20001/remoting/ios/facade/rem...
remoting/ios/facade/remoting_service.mm:110: [NSString
stringWithCString:host_info.host_os.c_str()
I did not know at the time, but there is a base chromium macro to convert std
strings to ns strings, can you update the usage here?

https://cs.chromium.org/chromium/src/base/strings/sys_string_conversions.h?ty...

I think you want to use SysUTF8ToNSString() and that replaces the entire
NSString stringWithCString blah blah.

[Yuwei, 2017-05-25 22:24:24]

Thanks!

https://codereview.chromium.org/2910513002/diff/20001/remoting/ios/facade/rem...
File remoting/ios/facade/remoting_service.mm (right):

https://codereview.chromium.org/2910513002/diff/20001/remoting/ios/facade/rem...
remoting/ios/facade/remoting_service.mm:110: [NSString
stringWithCString:host_info.host_os.c_str()
On 2017/05/25 21:51:47, nicholss wrote:
> I did not know at the time, but there is a base chromium macro to convert std
> strings to ns strings, can you update the usage here?
> 
>
https://cs.chromium.org/chromium/src/base/strings/sys_string_conversions.h?ty...
> 
> I think you want to use SysUTF8ToNSString() and that replaces the entire
> NSString stringWithCString blah blah.

Done. This is quite nice :)

[Yuwei, 2017-05-25 22:24:40]

The CQ bit was checked by yuweih@chromium.org

[Yuwei, 2017-05-25 22:24:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
nicholss@chromium.org
Link to the patchset: https://codereview.chromium.org/2910513002/#ps40001
(title: "Resolve feedback")

[commit-bot: I haz the power, 2017-05-25 22:25:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 22:58:21]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495751080035510,
"parent_rev": "d3422dd5e7cac07e39e06cca707c76eeaf4aa927", "commit_rev":
"f9ad97d4a86c4820fb02d73fb28bcd34ec4e3428"}

[commit-bot: I haz the power, 2017-05-25 22:58:36]

Description was changed from

==========
[CRD iOS] Fix telemetry issues

This CL fixes these issues:
* Previously the client OS is reported as Mac. That's because the OS_MACOSX
  macro is actually defined on iOS.
* Added the HostOs/HostVersion/HostOsVersion into the telemetry pipeline.

BUG=610866
==========

to

==========
[CRD iOS] Fix telemetry issues

This CL fixes these issues:
* Previously the client OS is reported as Mac. That's because the OS_MACOSX
  macro is actually defined on iOS.
* Added the HostOs/HostVersion/HostOsVersion into the telemetry pipeline.

BUG=610866

Review-Url: https://codereview.chromium.org/2910513002
Cr-Commit-Position: refs/heads/master@{#474835}
Committed:
https://chromium.googlesource.com/chromium/src/+/f9ad97d4a86c4820fb02d73fb28b...
==========

[commit-bot: I haz the power, 2017-05-25 22:58:39]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f9ad97d4a86c4820fb02d73fb28b...