Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Unified Diff: remoting/ios/session/remoting_client.mm

Issue 2910513002: [CRD iOS] Fix telemetry issues (Closed)
Patch Set: Resolve feedback Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/ios/facade/remoting_service.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/ios/session/remoting_client.mm
diff --git a/remoting/ios/session/remoting_client.mm b/remoting/ios/session/remoting_client.mm
index f5b76b4dc86b19410b4f2e6f4f86f0633267bcd5..f753f2286570d075a8013705c68db15612984f7a 100644
--- a/remoting/ios/session/remoting_client.mm
+++ b/remoting/ios/session/remoting_client.mm
@@ -84,6 +84,9 @@ NSString* const kHostSessionPin = @"kHostSessionPin";
info.host_jid = base::SysNSStringToUTF8(hostInfo.jabberId);
info.host_id = base::SysNSStringToUTF8(hostInfo.hostId);
info.host_pubkey = base::SysNSStringToUTF8(hostInfo.publicKey);
+ info.host_os = base::SysNSStringToUTF8(hostInfo.hostOs);
+ info.host_os_version = base::SysNSStringToUTF8(hostInfo.hostOsVersion);
+ info.host_version = base::SysNSStringToUTF8(hostInfo.hostVersion);
// TODO(nicholss): If iOS supports pairing, pull the stored data and
// insert it here.
info.pairing_id = "";
@@ -92,9 +95,6 @@ NSString* const kHostSessionPin = @"kHostSessionPin";
// TODO(nicholss): I am not sure about the following fields yet.
// info.capabilities =
// info.flags =
- // info.host_version =
- // info.host_os =
- // info.host_os_version =
remoting::protocol::ClientAuthenticationConfig client_auth_config;
client_auth_config.host_id = info.host_id;
« no previous file with comments | « remoting/ios/facade/remoting_service.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698