[CRD iOS] Fix telemetry issues

remoting/ios/facade/remoting_service.mm

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)
 #error "This file requires ARC support."
 #endif
 
 #import "remoting/ios/facade/remoting_service.h"
 
@@ skipping 79 matching lines @@
           switch (host_status) {
             case remoting::kHostStatusOnline:
               status = "ONLINE";
               break;
             case remoting::kHostStatusOffline:
               status = "OFFLINE";
               break;
             default:
               NOTREACHED();
           }
-          // TODO(nicholss): Not yet integrated: createdTime, hostVersion,
-          // kind, offlineReason. Add them as the app will need this info.
+          // TODO(nicholss): Not yet integrated: createdTime, kind,
+          // offlineReason. Add them as the app will need this info.
           HostInfo* host = [[HostInfo alloc] init];
           host.hostId =
               [NSString stringWithCString:host_info.host_id.c_str()
                                  encoding:[NSString defaultCStringEncoding]];
           host.hostName =
               [NSString stringWithCString:host_info.host_name.c_str()
                                  encoding:[NSString defaultCStringEncoding]];
+          host.hostOs =
+              [NSString stringWithCString:host_info.host_os.c_str()

[nicholss, 2017/05/25 21:51:47]

I did not know at the time, but there is a base chromium macro to convert std
strings to ns strings, can you update the usage here?

https://cs.chromium.org/chromium/src/base/strings/sys_string_conversions.h?ty...

I think you want to use SysUTF8ToNSString() and that replaces the entire
NSString stringWithCString blah blah.

[Yuwei, 2017/05/25 22:24:24]

Done. This is quite nice :)

+                                 encoding:[NSString defaultCStringEncoding]];
+          host.hostOsVersion =
+              [NSString stringWithCString:host_info.host_os_version.c_str()
+                                 encoding:[NSString defaultCStringEncoding]];
+          host.hostVersion =
+              [NSString stringWithCString:host_info.host_version.c_str()
+                                 encoding:[NSString defaultCStringEncoding]];
           host.jabberId =
               [NSString stringWithCString:host_info.host_jid.c_str()
                                  encoding:[NSString defaultCStringEncoding]];
           host.publicKey =
               [NSString stringWithCString:host_info.public_key.c_str()
                                  encoding:[NSString defaultCStringEncoding]];
           host.status =
               [NSString stringWithCString:status.c_str()
                                  encoding:[NSString defaultCStringEncoding]];
           [hosts addObject:host];
@@ skipping 48 matching lines @@
                                   const std::string& user_email,
                                   const std::string& access_token) {
         NSString* accessToken =
             [NSString stringWithCString:access_token.c_str()
                                encoding:[NSString defaultCStringEncoding]];
         [self startHostListFetchWith:accessToken];
       })];
 }
 
 @end