Propagate a user gesture bit for beforeinstallprompt.prompt()

Propagate a user gesture bit for beforeinstallprompt.prompt()

This is in preparation for experiments that will enforce a user gesture
to call beforeinstallprompt.prompt().

BUG=728022
Review-Url: https://codereview.chromium.org/2910363002
Cr-Commit-Position: refs/heads/master@{#476944}
Committed: https://chromium.googlesource.com/chromium/src/+/dafd5fb273d5135cddbd1c70ba16c619d5856b2b

[dominickn, 2017-05-31 05:22:18]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 05:22:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2017-05-31 05:22:45]

dominickn@chromium.org changed reviewers:
+ benwells@chromium.org

[dominickn, 2017-05-31 05:22:46]

PTAL, thanks!

[commit-bot: I haz the power, 2017-05-31 07:28:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 07:28:06]

Dry run: This issue passed the CQ dry run.

[benwells, 2017-06-01 01:34:37]

lgtm

[dominickn, 2017-06-01 01:36:37]

dominickn@chromium.org changed reviewers:
+ mkwst@chromium.org

[dominickn, 2017-06-01 01:36:38]

+mkwst: PTAL at the mojom changes. Everything else is a trivial addition of a
parameter to a method that will be used in the future.

[Mike West, 2017-06-01 10:44:08]

The mojo bit in particular LGTM.

I'm curious, though: where are you planning to consume the gesture?

[dominickn, 2017-06-01 12:15:22]

On 2017/06/01 10:44:08, Mike West wrote:
> The mojo bit in particular LGTM.
> 
> I'm curious, though: where are you planning to consume the gesture?

I modelled this on what permission prompts do, which is not consume the gesture
but report whether or not one is being processed to the browser (e.g.
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/geoloc...).
Add to homescreen and permissions seem relatively similar, hence the decision.
Not an expert here though so if you have thoughts I'm happy to hear them.

[Mike West, 2017-06-01 15:30:20]

mkwst@chromium.org changed reviewers:
+ jochen@chromium.org

[Mike West, 2017-06-01 15:30:20]

On 2017/06/01 at 12:15:22, dominickn wrote:
> On 2017/06/01 10:44:08, Mike West wrote:
> > The mojo bit in particular LGTM.
> > 
> > I'm curious, though: where are you planning to consume the gesture?
> 
> I modelled this on what permission prompts do, which is not consume the
gesture but report whether or not one is being processed to the browser (e.g.
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/geoloc...).
Add to homescreen and permissions seem relatively similar, hence the decision.
Not an expert here though so if you have thoughts I'm happy to hear them.

Depends on what you want. If the goal is just to ensure that a user clicked on
something, great. If the goal is to ensure that the user can only do one thing
with a click, you need to consume the gesture at some point so it can't be
reused by some other gesture-requiring thing (like `window.open`).

It's probably worth talking with jochen@ as the Grand Supreme Keeper of Gesture
Requirements for advice, but I don't think that discussion needs to block this
CL.

[dominickn, 2017-06-02 00:54:15]

The goal is just to ensure that a user clicked on something (well, as close as
we can approximate anyway). I'll follow up with jochen too. Thanks!

[dominickn, 2017-06-02 00:54:23]

The CQ bit was checked by dominickn@chromium.org

[commit-bot: I haz the power, 2017-06-02 00:54:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2017-06-02 01:01:27]

The CQ bit was unchecked by dominickn@chromium.org

[dominickn, 2017-06-02 01:01:58]

Oops, didn't see jochen was added as a reviewer. Before I land this jochen, do
you have any thoughts?

[jochen (gone - plz use gerrit), 2017-06-02 12:16:22]

as a rule of thumb, I think only creating a new process (e.g. via opening a
window) should destroy the user gesture, so this code lgtm

[dominickn, 2017-06-05 02:42:59]

The CQ bit was checked by dominickn@chromium.org

[commit-bot: I haz the power, 2017-06-05 02:43:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 05:12:21]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496630579587400, "parent_rev":
"7f9edaaa091bddbff260234e49b6c2988720c5a6", "commit_rev":
"dafd5fb273d5135cddbd1c70ba16c619d5856b2b"}

[commit-bot: I haz the power, 2017-06-05 05:12:33]

Description was changed from

==========
Propagate a user gesture bit for beforeinstallprompt.prompt()

This is in preparation for experiments that will enforce a user gesture
to call beforeinstallprompt.prompt().

BUG=728022
==========

to

==========
Propagate a user gesture bit for beforeinstallprompt.prompt()

This is in preparation for experiments that will enforce a user gesture
to call beforeinstallprompt.prompt().

BUG=728022

Review-Url: https://codereview.chromium.org/2910363002
Cr-Commit-Position: refs/heads/master@{#476944}
Committed:
https://chromium.googlesource.com/chromium/src/+/dafd5fb273d5135cddbd1c70ba16...
==========

[commit-bot: I haz the power, 2017-06-05 05:12:35]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dafd5fb273d5135cddbd1c70ba16...