third_party/WebKit/Source/modules/app_banner/BeforeInstallPromptEvent.cpp - Issue 2910363002: Propagate a user gesture bit for beforeinstallprompt.prompt()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/app_banner/BeforeInstallPromptEvent.cpp

Issue 2910363002: Propagate a user gesture bit for beforeinstallprompt.prompt() (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/test_runner/app_banner_service.cc ('k') | third_party/WebKit/public/platform/modules/app_banner/app_banner.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/app_banner/BeforeInstallPromptEvent.cpp

diff --git a/third_party/WebKit/Source/modules/app_banner/BeforeInstallPromptEvent.cpp b/third_party/WebKit/Source/modules/app_banner/BeforeInstallPromptEvent.cpp

index 096767aa483bbcc827a3c9795c2b2533e6a2b419..47d459e702891eab80438bad00dce023fbffae40 100644

--- a/third_party/WebKit/Source/modules/app_banner/BeforeInstallPromptEvent.cpp

+++ b/third_party/WebKit/Source/modules/app_banner/BeforeInstallPromptEvent.cpp

@@ -8,6 +8,7 @@

#include "core/dom/Document.h"

#include "core/dom/ExceptionCode.h"

#include "core/dom/ExecutionContext.h"

+#include "core/dom/UserGestureIndicator.h"

#include "core/frame/UseCounter.h"

#include "modules/app_banner/BeforeInstallPromptEventInit.h"

@@ -79,7 +80,8 @@ ScriptPromise BeforeInstallPromptEvent::prompt(ScriptState* script_state) {

UseCounter::kBeforeInstallPromptEventPrompt);

prompt_called_ = true;

- banner_service_->DisplayAppBanner();

+ banner_service_->DisplayAppBanner(

+ UserGestureIndicator::ProcessingUserGesture());

return ScriptPromise::CastUndefined(script_state);

}