chrome/browser/banners/app_banner_manager.cc - Issue 2910363002: Propagate a user gesture bit for beforeinstallprompt.prompt()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/banners/app_banner_manager.cc

Issue 2910363002: Propagate a user gesture bit for beforeinstallprompt.prompt() (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/banners/app_banner_manager.cc

diff --git a/chrome/browser/banners/app_banner_manager.cc b/chrome/browser/banners/app_banner_manager.cc

index 79a453dc26ca3f6b4259ff9fa23ca8fafa67255a..d13f2f9dde1d43586702bbf6c42bab18b6e59bac 100644

--- a/chrome/browser/banners/app_banner_manager.cc

+++ b/chrome/browser/banners/app_banner_manager.cc

@@ -555,7 +555,7 @@ void AppBannerManager::OnBannerPromptReply(

UpdateState(State::COMPLETE);

}

-void AppBannerManager::DisplayAppBanner() {

+void AppBannerManager::DisplayAppBanner(bool user_gesture) {

if (is_pending_event()) {

// Simulate a non-canceled OnBannerPromptReply to show the delayed banner.

OnBannerPromptReply(blink::mojom::AppBannerPromptReply::NONE, referrer_);