Replace deprecated base::NonThreadSafe in components/keyed_service in favor of SequenceChecker.

Replace deprecated base::NonThreadSafe in components/keyed_service in favor of SequenceChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implicitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2910053002
Cr-Commit-Position: refs/heads/master@{#475536}
Committed: https://chromium.googlesource.com/chromium/src/+/9d25e7c3befa903c9bef0950a1365b13d1074ae0

[gab, 2017-05-30 02:32:44]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[gab, 2017-05-30 02:32:46]

Hi, this is an automated change made by https://crbug.com/676387#c8 and sharded
across directories for OWNERS.

No human has looked at this specific output yet, see cl description for things
to watch for.

If it LGTY, please CQ.

If it didn't pass CQ dry-run it may be a simple patch failure or an IWYU failure
from having this being a partial CL... please review anyways and a human will
look at the failure (and ping for re-review if anything major is required..). It
is known to compile all targets on Windows at r474679...  manual tweaks will
likely be required to smoothen things off, bear with me!

Thanks!
Gab

[commit-bot: I haz the power, 2017-05-30 02:32:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 02:41:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 02:41:38]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Paweł Hajdan Jr., 2017-05-30 10:31:35]

LGTM

[Paweł Hajdan Jr., 2017-05-30 10:31:41]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2017-05-30 10:31:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 10:42:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 10:42:21]

Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[gab, 2017-05-30 14:08:10]

gab@chromium.org changed reviewers:
+ sdefresne@chromium.org

[gab, 2017-05-30 14:08:11]

Fixed compile by making matching adjustments to keyed_service\ios, +sdefresne
FYI

[gab, 2017-05-30 14:08:21]

The CQ bit was checked by gab@chromium.org

[gab, 2017-05-30 14:08:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
phajdan.jr@chromium.org
Link to the patchset: https://codereview.chromium.org/2910053002/#ps20001
(title: "add matching keyed_service\ios tweaks")

[commit-bot: I haz the power, 2017-05-30 14:08:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-05-30 14:16:45]

lgtm

In description, can you fix the typo in "implcitly".

[gab, 2017-05-30 14:23:13]

Description was changed from

==========
Replace deprecated base::NonThreadSafe in components/keyed_service in favor of
SequenceChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=phajdan.jr@chromium.org
==========

to

==========
Replace deprecated base::NonThreadSafe in components/keyed_service in favor of
SequenceChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implicitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=phajdan.jr@chromium.org
==========

[gab, 2017-05-30 14:24:01]

On 2017/05/30 14:16:45, sdefresne wrote:
> lgtm
> 
> In description, can you fix the typo in "implcitly".

Oops, I fixed it for this one but there are 78 CLs with this description out
there unfortunately... I think we can live with the unfortunate typo...

[commit-bot: I haz the power, 2017-05-30 15:31:05]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496153301851330,
"parent_rev": "6c0e82224a8455aafde554d79899a30b69173040", "commit_rev":
"9d25e7c3befa903c9bef0950a1365b13d1074ae0"}

[commit-bot: I haz the power, 2017-05-30 15:31:12]

Description was changed from

==========
Replace deprecated base::NonThreadSafe in components/keyed_service in favor of
SequenceChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implicitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=phajdan.jr@chromium.org
==========

to

==========
Replace deprecated base::NonThreadSafe in components/keyed_service in favor of
SequenceChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implicitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2910053002
Cr-Commit-Position: refs/heads/master@{#475536}
Committed:
https://chromium.googlesource.com/chromium/src/+/9d25e7c3befa903c9bef0950a136...
==========

[commit-bot: I haz the power, 2017-05-30 15:31:14]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9d25e7c3befa903c9bef0950a136...