Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: components/keyed_service/core/keyed_service_base_factory.h

Issue 2910053002: Replace deprecated base::NonThreadSafe in components/keyed_service in favor of SequenceChecker. (Closed)
Patch Set: add matching keyed_service\ios tweaks Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/keyed_service/core/keyed_service_base_factory.h
diff --git a/components/keyed_service/core/keyed_service_base_factory.h b/components/keyed_service/core/keyed_service_base_factory.h
index ea9223b0af3fda00ff0b544e253b4eb98b62584d..94d01d77c7bc021f86c2e96606d120b212a8adae 100644
--- a/components/keyed_service/core/keyed_service_base_factory.h
+++ b/components/keyed_service/core/keyed_service_base_factory.h
@@ -7,7 +7,7 @@
#include <set>
-#include "base/threading/non_thread_safe.h"
+#include "base/sequence_checker.h"
#include "components/keyed_service/core/dependency_node.h"
#include "components/keyed_service/core/keyed_service_export.h"
@@ -29,8 +29,7 @@ class PrefRegistrySyncable;
// This object describes general dependency management between factories while
// direct subclasses react to lifecycle events and implement memory management.
class KEYED_SERVICE_EXPORT KeyedServiceBaseFactory
- : public base::NonThreadSafe,
- NON_EXPORTED_BASE(public DependencyNode) {
+ : NON_EXPORTED_BASE(public DependencyNode) {
public:
#ifndef NDEBUG
// Returns our name. We don't keep track of this in release mode.
@@ -112,6 +111,8 @@ class KEYED_SERVICE_EXPORT KeyedServiceBaseFactory
// Mark context has having preferences registered.
void MarkPreferencesSetOn(base::SupportsUserData* context);
+ SEQUENCE_CHECKER(sequence_checker_);
+
private:
friend class DependencyManager;

Powered by Google App Engine
This is Rietveld 408576698