components/keyed_service/content/refcounted_browser_context_keyed_service_factory.cc - Issue 2910053002: Replace deprecated base::NonThreadSafe in components/keyed_service in favor of SequenceChecker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/keyed_service/content/refcounted_browser_context_keyed_service_factory.cc

Issue 2910053002: Replace deprecated base::NonThreadSafe in components/keyed_service in favor of SequenceChecker. (Closed)

Patch Set: add matching keyed_service\ios tweaks Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/keyed_service/content/browser_context_keyed_service_factory.cc ('k') | components/keyed_service/core/keyed_service_base_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/keyed_service/content/refcounted_browser_context_keyed_service_factory.cc

diff --git a/components/keyed_service/content/refcounted_browser_context_keyed_service_factory.cc b/components/keyed_service/content/refcounted_browser_context_keyed_service_factory.cc

index 7778de8abeec12788420809f63bc2abe467f9326..df8908ae50f6fcb615aca17fd6c7b5d522800ce1 100644

--- a/components/keyed_service/content/refcounted_browser_context_keyed_service_factory.cc

+++ b/components/keyed_service/content/refcounted_browser_context_keyed_service_factory.cc

@@ -50,7 +50,7 @@ content::BrowserContext*

RefcountedBrowserContextKeyedServiceFactory::GetBrowserContextToUse(

content::BrowserContext* context) const {

// TODO(crbug.com/701326): This DCHECK should be moved to GetContextToUse().

- DCHECK(CalledOnValidThread());

+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);

// Safe default for Incognito mode: no service.

if (context->IsOffTheRecord())