Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2909833002: Reland of Pass -Oz flag to Clang when targeting Android. (Closed)

Created:
3 years, 6 months ago by Nico
Modified:
3 years, 6 months ago
Reviewers:
pcc1, billorr
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Pass -Oz flag to Clang when targeting Android. (patchset #1 id:1 of https://codereview.chromium.org/2903983002/ ) Reason for revert: Crash cause got fixed, this should work now. Original issue's description: > Revert of Pass -Oz flag to Clang when targeting Android. (patchset #1 id:1 of https://codereview.chromium.org/2897283002/ ) > > Reason for revert: > This is causing Chrome to crash on start. See https://crbug.com/726137 for stack. > > Original issue's description: > > Pass -Oz flag to Clang when targeting Android. > > > > Relands https://codereview.chromium.org/1103393002 > > > > BUG=481675, 563748 > > > > Review-Url: https://codereview.chromium.org/2897283002 > > Cr-Commit-Position: refs/heads/master@{#474326} > > Committed: https://chromium.googlesource.com/chromium/src/+/3f60b5c86ff481f85ec5809ae1f94ef4c44d0b66 > > TBR=pcc@chromium.org,thakis@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=481675, 563748 > > Review-Url: https://codereview.chromium.org/2903983002 > Cr-Commit-Position: refs/heads/master@{#474485} > Committed: https://chromium.googlesource.com/chromium/src/+/b964d748bd770259233bb89425ba869829d3e4e0 TBR=pcc@chromium.org,billorr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=481675, 563748 Review-Url: https://codereview.chromium.org/2909833002 Cr-Commit-Position: refs/heads/master@{#475256} Committed: https://chromium.googlesource.com/chromium/src/+/bef80d93b4a5b160e66ceb6986fb31faa61fc892

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M build/config/compiler/BUILD.gn View 3 chunks +15 lines, -3 lines 0 comments Download
M third_party/expat/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
Nico
Created Reland of Pass -Oz flag to Clang when targeting Android.
3 years, 6 months ago (2017-05-28 04:35:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2909833002/1
3 years, 6 months ago (2017-05-28 04:35:13 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-05-28 06:12:23 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bef80d93b4a5b160e66ceb6986fb...

Powered by Google App Engine
This is Rietveld 408576698