Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2903983002: Revert of Pass -Oz flag to Clang when targeting Android. (Closed)

Created:
3 years, 7 months ago by billorr
Modified:
3 years, 7 months ago
Reviewers:
Nico, pcc1
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Pass -Oz flag to Clang when targeting Android. (patchset #1 id:1 of https://codereview.chromium.org/2897283002/ ) Reason for revert: This is causing Chrome to crash on start. See crbug/726137 for stack. Original issue's description: > Pass -Oz flag to Clang when targeting Android. > > Relands https://codereview.chromium.org/1103393002 > > BUG=481675, 563748 > > Review-Url: https://codereview.chromium.org/2897283002 > Cr-Commit-Position: refs/heads/master@{#474326} > Committed: https://chromium.googlesource.com/chromium/src/+/3f60b5c86ff481f85ec5809ae1f94ef4c44d0b66 TBR=pcc@chromium.org,thakis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=481675, 563748 Review-Url: https://codereview.chromium.org/2903983002 Cr-Commit-Position: refs/heads/master@{#474485} Committed: https://chromium.googlesource.com/chromium/src/+/b964d748bd770259233bb89425ba869829d3e4e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -20 lines) Patch
M build/config/compiler/BUILD.gn View 3 chunks +3 lines, -15 lines 0 comments Download
M third_party/expat/BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
billorr
Created Revert of Pass -Oz flag to Clang when targeting Android.
3 years, 7 months ago (2017-05-24 23:19:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2903983002/1
3 years, 7 months ago (2017-05-24 23:20:32 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-24 23:20:33 UTC) #5
pcc1
lgtm
3 years, 7 months ago (2017-05-24 23:21:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2903983002/1
3 years, 7 months ago (2017-05-25 00:14:38 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/b964d748bd770259233bb89425ba869829d3e4e0
3 years, 7 months ago (2017-05-25 00:15:29 UTC) #11
Nico
3 years, 6 months ago (2017-05-28 04:35:07 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2909833002/ by thakis@chromium.org.

The reason for reverting is: Crash cause got fixed, this should work now..

Powered by Google App Engine
This is Rietveld 408576698