Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 2897283002: Pass -Oz flag to Clang when targeting Android. (Closed)

Created:
3 years, 7 months ago by Nico
Modified:
3 years, 7 months ago
Reviewers:
pcc1
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass -Oz flag to Clang when targeting Android. Relands https://codereview.chromium.org/1103393002 BUG=481675, 563748 Review-Url: https://codereview.chromium.org/2897283002 Cr-Commit-Position: refs/heads/master@{#474326} Committed: https://chromium.googlesource.com/chromium/src/+/3f60b5c86ff481f85ec5809ae1f94ef4c44d0b66

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M build/config/compiler/BUILD.gn View 3 chunks +15 lines, -3 lines 0 comments Download
M third_party/expat/BUILD.gn View 1 chunk +5 lines, -0 lines 1 comment Download

Messages

Total messages: 13 (7 generated)
Nico
3 years, 7 months ago (2017-05-24 15:13:41 UTC) #3
Nico
https://codereview.chromium.org/2897283002/diff/1/third_party/expat/BUILD.gn File third_party/expat/BUILD.gn (right): https://codereview.chromium.org/2897283002/diff/1/third_party/expat/BUILD.gn#newcode37 third_party/expat/BUILD.gn:37: # libexpat with -Oz. (I checked that this no ...
3 years, 7 months ago (2017-05-24 15:33:35 UTC) #5
pcc1
LGTM
3 years, 7 months ago (2017-05-24 16:37:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897283002/1
3 years, 7 months ago (2017-05-24 16:43:56 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/3f60b5c86ff481f85ec5809ae1f94ef4c44d0b66
3 years, 7 months ago (2017-05-24 16:50:32 UTC) #12
billorr
3 years, 7 months ago (2017-05-24 23:19:51 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2903983002/ by billorr@chromium.org.

The reason for reverting is: This is causing Chrome to crash on start.  See
crbug/726137 for stack..

Powered by Google App Engine
This is Rietveld 408576698