Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 2909423002: Make TextUnderlinePosition an enum class. (Closed)

Created:
3 years, 6 months ago by shend
Modified:
3 years, 6 months ago
Reviewers:
dstockwell
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-paint_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, dshwang, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make TextUnderlinePosition an enum class. This patch makes TextUnderlinePosition an enum class for better type safety. BUG=684966 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2909423002 Cr-Commit-Position: refs/heads/master@{#475815} Committed: https://chromium.googlesource.com/chromium/src/+/6d317c3c73d4eadc4651c5a188c40b0296229e08

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/TextPainterBase.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
shend
Hi Eddy, PTAL
3 years, 6 months ago (2017-05-30 23:00:31 UTC) #4
shend
Hi Doug, PTAL
3 years, 6 months ago (2017-05-31 04:01:55 UTC) #9
dstockwell
lgtm
3 years, 6 months ago (2017-05-31 05:27:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2909423002/1
3 years, 6 months ago (2017-05-31 05:40:28 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 05:45:49 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6d317c3c73d4eadc4651c5a188c4...

Powered by Google App Engine
This is Rietveld 408576698