third_party/WebKit/Source/core/paint/TextPainterBase.cpp - Issue 2909423002: Make TextUnderlinePosition an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/TextPainterBase.cpp

Issue 2909423002: Make TextUnderlinePosition an enum class. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/TextPainterBase.cpp

diff --git a/third_party/WebKit/Source/core/paint/TextPainterBase.cpp b/third_party/WebKit/Source/core/paint/TextPainterBase.cpp

index bdfbac049183ee0915a17e77c45a9decf6bfe115..9f11fca4daccc6cc8f90de6bb61092c220874ede 100644

--- a/third_party/WebKit/Source/core/paint/TextPainterBase.cpp

+++ b/third_party/WebKit/Source/core/paint/TextPainterBase.cpp

@@ -199,9 +199,9 @@ static ResolvedUnderlinePosition ResolveUnderlinePosition(

switch (baseline_type) {

case kAlphabeticBaseline:

switch (style.GetTextUnderlinePosition()) {

- case kTextUnderlinePositionAuto:

+ case TextUnderlinePosition::kAuto:

return ResolvedUnderlinePosition::kRoman;

- case kTextUnderlinePositionUnder:

+ case TextUnderlinePosition::kUnder:

return ResolvedUnderlinePosition::kUnder;

}

break;