Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Unified Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

Issue 2909423002: Make TextUnderlinePosition an enum class. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSProperties.json5 » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
diff --git a/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h b/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
index 70fe4f80755cbb2c442de8ca6538ee420a8348ac..1fc5d6e5a39cc054dbd98e583fe593c614cfdaeb 100644
--- a/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
+++ b/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
@@ -1146,10 +1146,10 @@ template <>
inline CSSIdentifierValue::CSSIdentifierValue(TextUnderlinePosition e)
: CSSValue(kIdentifierClass) {
switch (e) {
- case kTextUnderlinePositionAuto:
+ case TextUnderlinePosition::kAuto:
value_id_ = CSSValueAuto;
break;
- case kTextUnderlinePositionUnder:
+ case TextUnderlinePosition::kUnder:
value_id_ = CSSValueUnder;
break;
}
@@ -1161,9 +1161,9 @@ template <>
inline TextUnderlinePosition CSSIdentifierValue::ConvertTo() const {
switch (value_id_) {
case CSSValueAuto:
- return kTextUnderlinePositionAuto;
+ return TextUnderlinePosition::kAuto;
case CSSValueUnder:
- return kTextUnderlinePositionUnder;
+ return TextUnderlinePosition::kUnder;
default:
break;
}
@@ -1171,7 +1171,7 @@ inline TextUnderlinePosition CSSIdentifierValue::ConvertTo() const {
// FIXME: Implement support for 'under left' and 'under right' values.
NOTREACHED();
- return kTextUnderlinePositionAuto;
+ return TextUnderlinePosition::kAuto;
}
template <>
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSProperties.json5 » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698