Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 2909223002: Renamed WebViewBase::ChromeClient to GetChromeClient (Closed)

Created:
3 years, 6 months ago by sashab
Modified:
3 years, 6 months ago
Reviewers:
slangley, haraken, dcheng
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kinuko+watch, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Renamed WebViewBase::ChromeClient to GetChromeClient Renamed WebViewBase::ChromeClient to GetChromeClient to resolve a naming conflict, and be able to use the type ChromeClient without the explicit blink:: qualifier. Review-Url: https://codereview.chromium.org/2909223002 Cr-Commit-Position: refs/heads/master@{#475687} Committed: https://chromium.googlesource.com/chromium/src/+/2a79c205860367a37c4243dfe632c8ec13345306

Patch Set 1 #

Patch Set 2 : Removed blink:: qualifier #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M third_party/WebKit/Source/core/exported/WebViewBase.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/ValidationMessageClientImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 1 2 chunks +2 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 20 (13 generated)
sashab
3 years, 6 months ago (2017-05-30 03:49:27 UTC) #4
slangley
lgtm
3 years, 6 months ago (2017-05-30 03:54:31 UTC) #5
dcheng
lgtm
3 years, 6 months ago (2017-05-30 03:57:01 UTC) #6
commit-bot: I haz the power
This CL has an open dependency (Issue 2887523003 Patch 80001). Please resolve the dependency and ...
3 years, 6 months ago (2017-05-30 03:58:51 UTC) #10
haraken
LGTM
3 years, 6 months ago (2017-05-30 05:21:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2909223002/20001
3 years, 6 months ago (2017-05-30 22:42:28 UTC) #17
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 22:51:59 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2a79c205860367a37c4243dfe632...

Powered by Google App Engine
This is Rietveld 408576698