third_party/WebKit/Source/core/page/ValidationMessageClientImpl.cpp - Issue 2909223002: Renamed WebViewBase::ChromeClient to GetChromeClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/ValidationMessageClientImpl.cpp

Issue 2909223002: Renamed WebViewBase::ChromeClient to GetChromeClient (Closed)

Patch Set: Removed blink:: qualifier Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/exported/WebViewBase.h ('k') | third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/ValidationMessageClientImpl.cpp

diff --git a/third_party/WebKit/Source/core/page/ValidationMessageClientImpl.cpp b/third_party/WebKit/Source/core/page/ValidationMessageClientImpl.cpp

index 39d3d2ec908702d18803a35d600f8a9cb122d2e1..f2e3c3bc44b3c0a71619a3ce8c4b2ea704e121cc 100644

--- a/third_party/WebKit/Source/core/page/ValidationMessageClientImpl.cpp

+++ b/third_party/WebKit/Source/core/page/ValidationMessageClientImpl.cpp

@@ -85,7 +85,7 @@ void ValidationMessageClientImpl::ShowValidationMessage(

web_view_.Client()->ShowValidationMessage(

anchor_in_viewport, message_, ToWebTextDirection(message_dir),

sub_message, ToWebTextDirection(sub_message_dir));

- web_view_.ChromeClient().RegisterPopupOpeningObserver(this);

+ web_view_.GetChromeClient().RegisterPopupOpeningObserver(this);

finish_time_ =

MonotonicallyIncreasingTime() +

@@ -107,7 +107,7 @@ void ValidationMessageClientImpl::HideValidationMessage(const Element& anchor) {

message_ = String();

finish_time_ = 0;

web_view_.Client()->HideValidationMessage();

- web_view_.ChromeClient().UnregisterPopupOpeningObserver(this);

+ web_view_.GetChromeClient().UnregisterPopupOpeningObserver(this);

}

bool ValidationMessageClientImpl::IsValidationMessageVisible(

« no previous file with comments | « third_party/WebKit/Source/core/exported/WebViewBase.h ('k') | third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp » ('j') | no next file with comments »