Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Side by Side Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 2909223002: Renamed WebViewBase::ChromeClient to GetChromeClient (Closed)
Patch Set: Removed blink:: qualifier Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 478 matching lines...) Expand 10 before | Expand all | Expand 10 after
489 WebDisplayMode DisplayMode() const override { return display_mode_; } 489 WebDisplayMode DisplayMode() const override { return display_mode_; }
490 490
491 PageScaleConstraintsSet& GetPageScaleConstraintsSet() const override; 491 PageScaleConstraintsSet& GetPageScaleConstraintsSet() const override;
492 492
493 FloatSize ElasticOverscroll() const override { return elastic_overscroll_; } 493 FloatSize ElasticOverscroll() const override { return elastic_overscroll_; }
494 494
495 double LastFrameTimeMonotonic() const override { 495 double LastFrameTimeMonotonic() const override {
496 return last_frame_time_monotonic_; 496 return last_frame_time_monotonic_;
497 } 497 }
498 498
499 class ChromeClient& ChromeClient() const override { 499 class ChromeClient& GetChromeClient() const override {
500 return *chrome_client_.Get(); 500 return *chrome_client_.Get();
501 } 501 }
502 502
503 // Returns the currently active WebInputMethodController which is the one 503 // Returns the currently active WebInputMethodController which is the one
504 // corresponding to the focused frame. It will return nullptr if there is no 504 // corresponding to the focused frame. It will return nullptr if there is no
505 // focused frame, or if the there is one but it belongs to a different local 505 // focused frame, or if the there is one but it belongs to a different local
506 // root. 506 // root.
507 WebInputMethodController* GetActiveWebInputMethodController() const; 507 WebInputMethodController* GetActiveWebInputMethodController() const;
508 508
509 void SetLastHiddenPagePopup(WebPagePopupImpl* page_popup) override { 509 void SetLastHiddenPagePopup(WebPagePopupImpl* page_popup) override {
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
596 void DetachCompositorAnimationTimeline(CompositorAnimationTimeline*); 596 void DetachCompositorAnimationTimeline(CompositorAnimationTimeline*);
597 597
598 LocalFrame* FocusedLocalFrameInWidget() const; 598 LocalFrame* FocusedLocalFrameInWidget() const;
599 LocalFrame* FocusedLocalFrameAvailableForIme() const; 599 LocalFrame* FocusedLocalFrameAvailableForIme() const;
600 600
601 CompositorMutatorImpl& Mutator(); 601 CompositorMutatorImpl& Mutator();
602 602
603 WebViewClient* client_; // Can be 0 (e.g. unittests, shared workers, etc.) 603 WebViewClient* client_; // Can be 0 (e.g. unittests, shared workers, etc.)
604 WebSpellCheckClient* spell_check_client_; 604 WebSpellCheckClient* spell_check_client_;
605 605
606 // ChromeClient needs blink:: qualifier so it doesn't clash with ChromeClient 606 Persistent<ChromeClient> chrome_client_;
607 // method. TODO(sashab): Rename getter to GetChromeClient to fix this.
608 Persistent<blink::ChromeClient> chrome_client_;
609 ContextMenuClientImpl context_menu_client_impl_; 607 ContextMenuClientImpl context_menu_client_impl_;
610 EditorClientImpl editor_client_impl_; 608 EditorClientImpl editor_client_impl_;
611 SpellCheckerClientImpl spell_checker_client_impl_; 609 SpellCheckerClientImpl spell_checker_client_impl_;
612 StorageClientImpl storage_client_impl_; 610 StorageClientImpl storage_client_impl_;
613 611
614 WebSize size_; 612 WebSize size_;
615 // If true, automatically resize the layout view around its content. 613 // If true, automatically resize the layout view around its content.
616 bool should_auto_resize_; 614 bool should_auto_resize_;
617 // The lower bound on the size when auto-resizing. 615 // The lower bound on the size when auto-resizing.
618 IntSize min_auto_size_; 616 IntSize min_auto_size_;
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
745 Persistent<ResizeViewportAnchor> resize_viewport_anchor_; 743 Persistent<ResizeViewportAnchor> resize_viewport_anchor_;
746 }; 744 };
747 745
748 // We have no ways to check if the specified WebView is an instance of 746 // We have no ways to check if the specified WebView is an instance of
749 // WebViewImpl because WebViewImpl is the only implementation of WebView. 747 // WebViewImpl because WebViewImpl is the only implementation of WebView.
750 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true); 748 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true);
751 749
752 } // namespace blink 750 } // namespace blink
753 751
754 #endif 752 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698