Deprecate NonThreadSafe in content/renderer/media in favor of SequenceChecker.

Deprecate NonThreadSafe in content/renderer/media in favor of SequenceChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=wolenetz@chromium.org

Review-Url: https://codereview.chromium.org/2909103002
Cr-Commit-Position: refs/heads/master@{#476688}
Committed: https://chromium.googlesource.com/chromium/src/+/a58cd0bd4e7fee28aceddd7a6310f820cace3f7d

[gab, 2017-05-29 19:16:42]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[gab, 2017-05-29 19:16:44]

Hi, this is an automated change made by https://crbug.com/676387#c8 and sharded
across directories for OWNERS.

No human has looked at this specific output yet, see cl description for things
to watch for.

If it LGTY, please CQ.

If it didn't pass CQ dry-run it may be a simple patch failure or an IWYU failure
from having this being a partial CL... please review anyways and a human will
look at the failure (and ping for re-review if anything major is required..). It
is known to compile all targets on Windows at r474679...  manual tweaks will
likely be required to smoothen things off, bear with me!

Thanks!
Gab

[commit-bot: I haz the power, 2017-05-29 19:16:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 19:25:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 19:25:20]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[gab, 2017-05-30 01:25:41]

Description was changed from

==========
Deprecate NonThreadSafe in content/renderer/media in favor of SequenceChecker.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=wolenetz@chromium.org
==========

to

==========
Deprecate NonThreadSafe in content/renderer/media in favor of SequenceChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=wolenetz@chromium.org
==========

[gab, 2017-05-30 14:20:21]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 14:20:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 15:31:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 15:31:56]

Dry run: This issue passed the CQ dry run.

[gab, 2017-06-01 19:09:09]

gab@chromium.org changed reviewers:
+ emircan@chromium.org, mcasas@chromium.org
- wolenetz@chromium.org

[gab, 2017-06-01 19:09:10]

s/wolenetz/mcasas/ (git cl owners prioritizes file:// over other owners so
parses content\renderer\media\OWNERS incorrectly).

Please CQ if LGTYs

+emircan for webrtc FYI just in case.

[gab, 2017-06-02 14:33:03]

On 2017/06/01 19:09:10, gab wrote:
> s/wolenetz/mcasas/ (git cl owners prioritizes file:// over other owners so
> parses content\renderer\media\OWNERS incorrectly).
> 
> Please CQ if LGTYs
> 
> +emircan for webrtc FYI just in case.

Can someone pleasseeeee look at this today... it's the last of 78 CLs sharded by
this script and it's been out for nearly 4 days...

[mcasas, 2017-06-02 15:01:14]

https://codereview.chromium.org/2909103002/diff/20001/content/renderer/media/...
File content/renderer/media/webrtc_uma_histograms.h (right):

https://codereview.chromium.org/2909103002/diff/20001/content/renderer/media/...
content/renderer/media/webrtc_uma_histograms.h:99: bool
has_used_api_[INVALID_NAME];
<rant mode>
Ugh, this should be s/INVALID_NAME/NUM_APIS/ or some such.
</rant mode>

[mcasas, 2017-06-02 15:01:42]

On 2017/06/02 15:01:14, mcasas wrote:
>
https://codereview.chromium.org/2909103002/diff/20001/content/renderer/media/...
> File content/renderer/media/webrtc_uma_histograms.h (right):
> 
>
https://codereview.chromium.org/2909103002/diff/20001/content/renderer/media/...
> content/renderer/media/webrtc_uma_histograms.h:99: bool
> has_used_api_[INVALID_NAME];
> <rant mode>
> Ugh, this should be s/INVALID_NAME/NUM_APIS/ or some such.
> </rant mode>

lgtm sorry for the delay, I somehow misread that you
were passing it to wolenetz@ and not the other way around.

[gab, 2017-06-02 15:15:29]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2017-06-02 15:15:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 16:32:33]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496416529927660,
"parent_rev": "e324f5554328849a457d09730c12be0c53921ab6", "commit_rev":
"5fad99990d0c9ffeffe3da3f1e59828f7c1874a6"}

[commit-bot: I haz the power, 2017-06-02 16:32:46]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496416529927660,
"parent_rev": "160b06e61b41f9205fd9c0c0db4a2ec45fd0c305", "commit_rev":
"c26d2894a5acec55e41e16066c62e473055dfb1d"}

[commit-bot: I haz the power, 2017-06-02 16:33:04]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496416529927660,
"parent_rev": "55fd9698cf58d1f2899a9050c4e143bacdf503a2", "commit_rev":
"a58cd0bd4e7fee28aceddd7a6310f820cace3f7d"}

[commit-bot: I haz the power, 2017-06-02 16:33:14]

Description was changed from

==========
Deprecate NonThreadSafe in content/renderer/media in favor of SequenceChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=wolenetz@chromium.org
==========

to

==========
Deprecate NonThreadSafe in content/renderer/media in favor of SequenceChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=wolenetz@chromium.org

Review-Url: https://codereview.chromium.org/2909103002
Cr-Commit-Position: refs/heads/master@{#476688}
Committed:
https://chromium.googlesource.com/chromium/src/+/a58cd0bd4e7fee28aceddd7a6310...
==========

[commit-bot: I haz the power, 2017-06-02 16:33:16]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a58cd0bd4e7fee28aceddd7a6310...