Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2684)

Unified Diff: content/renderer/media/webrtc_uma_histograms.h

Issue 2909103002: Deprecate NonThreadSafe in content/renderer/media in favor of SequenceChecker. (Closed)
Patch Set: fix compile Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/webrtc_audio_renderer.h ('k') | content/renderer/media/webrtc_uma_histograms.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/webrtc_uma_histograms.h
diff --git a/content/renderer/media/webrtc_uma_histograms.h b/content/renderer/media/webrtc_uma_histograms.h
index e333178d66b58cc28bc2940d6e654e5037da2f17..4b72816e5488eae9e25b2d043936d2831e93f640 100644
--- a/content/renderer/media/webrtc_uma_histograms.h
+++ b/content/renderer/media/webrtc_uma_histograms.h
@@ -7,7 +7,7 @@
#include "base/macros.h"
#include "base/memory/singleton.h"
-#include "base/threading/non_thread_safe.h"
+#include "base/sequence_checker.h"
#include "content/common/content_export.h"
#include "content/public/common/media_stream_request.h"
@@ -66,7 +66,7 @@ void UpdateWebRTCMethodCount(JavaScriptAPIName api_name);
//
// The UpdateWebRTCMethodCount function above uses this class to log a
// metric at most once per session.
-class CONTENT_EXPORT PerSessionWebRTCAPIMetrics : public base::NonThreadSafe {
+class CONTENT_EXPORT PerSessionWebRTCAPIMetrics {
public:
virtual ~PerSessionWebRTCAPIMetrics();
@@ -98,6 +98,8 @@ class CONTENT_EXPORT PerSessionWebRTCAPIMetrics : public base::NonThreadSafe {
int num_streams_;
bool has_used_api_[INVALID_NAME];
mcasas 2017/06/02 15:01:13 <rant mode> Ugh, this should be s/INVALID_NAME/NUM
+ SEQUENCE_CHECKER(sequence_checker_);
+
DISALLOW_COPY_AND_ASSIGN(PerSessionWebRTCAPIMetrics);
};
« no previous file with comments | « content/renderer/media/webrtc_audio_renderer.h ('k') | content/renderer/media/webrtc_uma_histograms.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698