content/renderer/media/rtc_dtmf_sender_handler.cc - Issue 2909103002: Deprecate NonThreadSafe in content/renderer/media in favor of SequenceChecker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/rtc_dtmf_sender_handler.cc

Issue 2909103002: Deprecate NonThreadSafe in content/renderer/media in favor of SequenceChecker. (Closed)

Patch Set: fix compile Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/rtc_dtmf_sender_handler.cc

diff --git a/content/renderer/media/rtc_dtmf_sender_handler.cc b/content/renderer/media/rtc_dtmf_sender_handler.cc

index 0c46a1f91db83ce35fed86dc014d8013b7666dd5..a5761522df30f2c17a23e6f2f62882f5579ba27d 100644

--- a/content/renderer/media/rtc_dtmf_sender_handler.cc

+++ b/content/renderer/media/rtc_dtmf_sender_handler.cc

@@ -57,6 +57,7 @@ RtcDtmfSenderHandler::RtcDtmfSenderHandler(DtmfSenderInterface* dtmf_sender)

}

RtcDtmfSenderHandler::~RtcDtmfSenderHandler() {

+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);

DVLOG(1) << "::dtor";

dtmf_sender_->UnregisterObserver();

// Release |observer| before |weak_factory_| is destroyed.