Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2908933002: Make PageSizeType an enum class. (Closed)

Created:
3 years, 6 months ago by shend
Modified:
3 years, 6 months ago
Reviewers:
meade_UTC10, haraken
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, kinuko+watch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make PageSizeType an enum class. This patch makes PageSizeType an enum class for better type safety. BUG=684966 Review-Url: https://codereview.chromium.org/2908933002 Cr-Commit-Position: refs/heads/master@{#475479} Committed: https://chromium.googlesource.com/chromium/src/+/9c4d96f6224765185e9320832cb5ce5ab21ad748

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -21 lines) Patch
M third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareNonInheritedData.h View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareNonInheritedData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 23 (15 generated)
shend
Hi Eddy, PTAL
3 years, 6 months ago (2017-05-28 23:19:27 UTC) #4
meade_UTC10
lgtm
3 years, 6 months ago (2017-05-30 03:48:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2908933002/1
3 years, 6 months ago (2017-05-30 07:01:00 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/450469)
3 years, 6 months ago (2017-05-30 07:09:07 UTC) #15
shend
Hi Haraken, PTAL for web/
3 years, 6 months ago (2017-05-30 07:22:53 UTC) #17
haraken
LGTM
3 years, 6 months ago (2017-05-30 07:31:20 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2908933002/1
3 years, 6 months ago (2017-05-30 07:35:38 UTC) #20
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 09:35:35 UTC) #23
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9c4d96f6224765185e9320832cb5...

Powered by Google App Engine
This is Rietveld 408576698