Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2907073002: Move PageSizeAuto to ComputedStyleConstants.h. (Closed)

Created:
3 years, 6 months ago by shend
Modified:
3 years, 6 months ago
Reviewers:
meade_UTC10
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move PageSizeAuto to ComputedStyleConstants.h. StyleRareNonInheritedData.h has an enum called PageSizeAuto. When we generate StyleRareNonInheritedData.h, this enum can no longer be defined in that file. This patch moves PageSizeAuto to ComputedStyleConstants.h so that we can continue to ues it after we've generated StyleRareNonInheritedData. BUG=628043 Review-Url: https://codereview.chromium.org/2907073002 Cr-Commit-Position: refs/heads/master@{#475488} Committed: https://chromium.googlesource.com/chromium/src/+/36d3ee32727627fb3bde2990eb43de8c85879183

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareNonInheritedData.h View 1 chunk +0 lines, -10 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (12 generated)
shend
Hi Eddy, PTAL
3 years, 6 months ago (2017-05-28 23:19:42 UTC) #4
meade_UTC10
lgtm
3 years, 6 months ago (2017-05-30 03:48:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2907073002/1
3 years, 6 months ago (2017-05-30 10:38:36 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 10:42:56 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/36d3ee32727627fb3bde2990eb43...

Powered by Google App Engine
This is Rietveld 408576698