Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Side by Side Diff: third_party/WebKit/Source/core/style/StyleRareNonInheritedData.h

Issue 2908933002: Make PageSizeType an enum class. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2003, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 5 * Copyright (C) 2003, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
6 * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com) 6 * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 class StyleGridData; 59 class StyleGridData;
60 class StyleGridItemData; 60 class StyleGridItemData;
61 class StyleMultiColData; 61 class StyleMultiColData;
62 class StyleNonInheritedVariables; 62 class StyleNonInheritedVariables;
63 class StyleReflection; 63 class StyleReflection;
64 class StyleTransformData; 64 class StyleTransformData;
65 class StyleWillChangeData; 65 class StyleWillChangeData;
66 66
67 // Page size type. 67 // Page size type.
68 // StyleRareNonInheritedData::page_size_ is meaningful only when 68 // StyleRareNonInheritedData::page_size_ is meaningful only when
69 // StyleRareNonInheritedData::page_size_type_ is PAGE_SIZE_RESOLVED. 69 // StyleRareNonInheritedData::page_size_type_ is kResolved.
70 enum PageSizeType { 70 enum class PageSizeType {
71 PAGE_SIZE_AUTO, // size: auto 71 kAuto, // size: auto
72 PAGE_SIZE_AUTO_LANDSCAPE, // size: landscape 72 kLandscape, // size: landscape
73 PAGE_SIZE_AUTO_PORTRAIT, // size: portrait 73 kPortrait, // size: portrait
74 PAGE_SIZE_RESOLVED // Size is fully resolved. 74 kResolved // Size is fully resolved.
75 }; 75 };
76 76
77 // This struct is for rarely used non-inherited CSS3, CSS2, and WebKit-specific 77 // This struct is for rarely used non-inherited CSS3, CSS2, and WebKit-specific
78 // properties. By grouping them together, we save space, and only allocate this 78 // properties. By grouping them together, we save space, and only allocate this
79 // object when someone actually uses one of these properties. 79 // object when someone actually uses one of these properties.
80 // TODO(sashab): Move this into a private class on ComputedStyle, and remove 80 // TODO(sashab): Move this into a private class on ComputedStyle, and remove
81 // all methods on it, merging them into copy/creation methods on ComputedStyle 81 // all methods on it, merging them into copy/creation methods on ComputedStyle
82 // instead. Keep the allocation logic, only allocating a new object if needed. 82 // instead. Keep the allocation logic, only allocating a new object if needed.
83 class CORE_EXPORT StyleRareNonInheritedData 83 class CORE_EXPORT StyleRareNonInheritedData
84 : public RefCounted<StyleRareNonInheritedData> { 84 : public RefCounted<StyleRareNonInheritedData> {
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 unsigned has_author_border_ : 1; // Whether there is a author-defined border. 228 unsigned has_author_border_ : 1; // Whether there is a author-defined border.
229 229
230 private: 230 private:
231 StyleRareNonInheritedData(); 231 StyleRareNonInheritedData();
232 StyleRareNonInheritedData(const StyleRareNonInheritedData&); 232 StyleRareNonInheritedData(const StyleRareNonInheritedData&);
233 }; 233 };
234 234
235 } // namespace blink 235 } // namespace blink
236 236
237 #endif // StyleRareNonInheritedData_h 237 #endif // StyleRareNonInheritedData_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698