Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2908823002: Fix the handling of the text prosessing items in the popup menu (Closed)

Created:
3 years, 7 months ago by Tima Vaisburd
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Fix the handling of the text prosessing items in the popup menu The prior code wrongly assumed that the item ID of a MenuItem can not be zero. Because of this for zero ID items prior to Android O the wrong method (doAssistAction()) was called which did not do anything. This fix removes doAssistAction() from valid choices prior to Android O. BUG=726252 Review-Url: https://codereview.chromium.org/2899043007 Cr-Original-Commit-Position: refs/heads/master@{#475101} Review-Url: https://codereview.chromium.org/2908823002 . Cr-Commit-Position: refs/branch-heads/3071@{#705} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/4462e6b2ef4336dc80b27cfc81d2e3a5c55679e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Tima Vaisburd
3 years, 7 months ago (2017-05-26 20:32:38 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4462e6b2ef4336dc80b27cfc81d2e3a5c55679e0.

Powered by Google App Engine
This is Rietveld 408576698