Fix the handling of the text prosessing items in the popup menu

Fix the handling of the text prosessing items in the popup menu

The prior code wrongly assumed that the item ID of a MenuItem
can not be zero. Because of this for zero ID items prior to
Android O the wrong method (doAssistAction()) was called which
did not do anything.

This fix removes doAssistAction() from valid choices prior to
Android O.

BUG=726252
Review-Url: https://codereview.chromium.org/2899043007
Cr-Commit-Position: refs/heads/master@{#475101}
Committed: https://chromium.googlesource.com/chromium/src/+/a978f857db529cd85a416d5b6b274b1fb148c9c8

[Tima Vaisburd, 2017-05-26 01:40:43]

timav@chromium.org changed reviewers:
+ amaralp@chromium.org, tedchoc@chromium.org

[Tima Vaisburd, 2017-05-26 01:40:44]

A minimal fix so we can merge. PTAL.

[Tima Vaisburd, 2017-05-26 14:56:47]

The CQ bit was checked by timav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 14:56:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 15:42:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 15:42:32]

Dry run: This issue passed the CQ dry run.

[amaralp, 2017-05-26 18:15:49]

lgtm

[Ted C, 2017-05-26 18:19:33]

lgtm

[Tima Vaisburd, 2017-05-26 19:46:23]

The CQ bit was checked by timav@chromium.org

[commit-bot: I haz the power, 2017-05-26 19:47:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 20:12:11]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495827983056540, "parent_rev":
"e87e6f6da577dfdacf64dab57c4e0b8533d63a16", "commit_rev":
"a978f857db529cd85a416d5b6b274b1fb148c9c8"}

[commit-bot: I haz the power, 2017-05-26 20:12:26]

Description was changed from

==========
Fix the handling of the text prosessing items in the popup menu

The prior code wrongly assumed that the item ID of a MenuItem
can not be zero. Because of this for zero ID items prior to
Android O the wrong method (doAssistAction()) was called which
did not do anything.

This fix removes doAssistAction() from valid choices prior to
Android O.

BUG=726252
==========

to

==========
Fix the handling of the text prosessing items in the popup menu

The prior code wrongly assumed that the item ID of a MenuItem
can not be zero. Because of this for zero ID items prior to
Android O the wrong method (doAssistAction()) was called which
did not do anything.

This fix removes doAssistAction() from valid choices prior to
Android O.

BUG=726252

Review-Url: https://codereview.chromium.org/2899043007
Cr-Commit-Position: refs/heads/master@{#475101}
Committed:
https://chromium.googlesource.com/chromium/src/+/a978f857db529cd85a416d5b6b27...
==========

[commit-bot: I haz the power, 2017-05-26 20:12:28]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a978f857db529cd85a416d5b6b27...